Re: [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events)

[Peter Zijlstra <peterz@infradead.org>]

On Tue, Aug 06, 2013 at 06:08:26PM +0200, Oleg Nesterov wrote:
> On 08/05, Steven Rostedt wrote:
> >
> > > Sorry... should I resend once again ?
> >
> > Sure, why not. It's only 3 patches :-)
> 
> OK. Added "v2" to avoid the confusion.
> 
> The only change is
> 
> 	- Reviewed-and-Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 	+ Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
> 	+ Acked-by: Steven Rostedt <rostedt@goodmis.org>
> 	
> > I wonder if the Reviewed-by assumes the Acked-by?
> 
> I dunno. But since you gave me both, I'd better preserve them all.

So I suppose the down-side to putting them in TP_ARGS() is that you
cannot use arbitrary expressions for them anymore; like:

  TP_ARGS(foo);

  TP_perf_assign(
    __perf_task(foo->ponies);
    __perf_count(foo->horses);
  ),

Not that we actually did something like that, but I imagine it might've
been useful.. A well, lets not worry too much about that and go with
this. We'll get creative again if we ever need something like that.

Acked-by: Peter Zijlstra <peterz@infradead.org>

Thanks!