From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
David Ahern <dsahern@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"zhangwei(Jovi)" <jovi.zhangwei@huawei.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events)
Date: Mon, 12 Aug 2013 19:45:15 +0200 [thread overview]
Message-ID: <20130812174515.GA14359@redhat.com> (raw)
In-Reply-To: <20130812150945.GL27162@twins.programming.kicks-ass.net>
On 08/12, Peter Zijlstra wrote:
>
> So I suppose the down-side to putting them in TP_ARGS() is that you
> cannot use arbitrary expressions for them anymore; like:
>
> TP_ARGS(foo);
>
> TP_perf_assign(
> __perf_task(foo->ponies);
> __perf_count(foo->horses);
> ),
>
> Not that we actually did something like that, but I imagine it might've
> been useful..
Yes. This is of course less generic. And more confusing, I agree.
> A well, lets not worry too much about that and go with
> this. We'll get creative again if we ever need something like that.
>
> Acked-by: Peter Zijlstra <peterz@infradead.org>
Thanks ;)
BTW. Can't we kill __perf_addr() and the corresponding argument in
perf_trace_buf_submit/perf_tp_event ?
Or do you think it can have a new user?
Oleg.
next prev parent reply other threads:[~2013-08-12 17:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 16:08 [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events) Oleg Nesterov
2013-08-06 16:08 ` [PATCH v2 1/3] tracing/perf: Expand TRACE_EVENT(sched_stat_runtime) Oleg Nesterov
2013-08-15 19:48 ` [tip:perf/core] tracing/perf: Expand TRACE_EVENT( sched_stat_runtime) tip-bot for Oleg Nesterov
2013-08-06 16:08 ` [PATCH v2 2/3] tracing/perf: Reimplement TP_perf_assign() logic Oleg Nesterov
2013-08-15 19:48 ` [tip:perf/core] " tip-bot for Oleg Nesterov
2013-08-06 16:08 ` [PATCH v2 3/3] tracing/perf: Avoid perf_trace_buf_*() in perf_trace_##call() when possible Oleg Nesterov
2013-08-15 19:49 ` [tip:perf/core] " tip-bot for Oleg Nesterov
2013-08-12 15:09 ` [PATCH v2 0/3] Teach perf_trace_##call() to check hlist_empty(perf_events) Peter Zijlstra
2013-08-12 17:45 ` Oleg Nesterov [this message]
2013-08-13 7:47 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812174515.GA14359@redhat.com \
--to=oleg@redhat.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jovi.zhangwei@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox