From: Ingo Molnar <mingo@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, acme@infradead.org,
Andi Kleen <ak@linux.intel.com>,
Namhyung Kim <namhyung.kim@lge.com>,
peterz@infradead.org
Subject: Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable
Date: Mon, 12 Aug 2013 20:19:56 +0200 [thread overview]
Message-ID: <20130812181956.GB19405@gmail.com> (raw)
In-Reply-To: <20130806061932.GA20485@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Aug 05, 2013 at 11:08:57AM +0200, Ingo Molnar wrote:
> > You never replied to the original counter-arguments, such as this one from
> > Linus:
> >
> > http://article.gmane.org/gmane.linux.kernel/849965
>
> The only thing Linus sais is that it's trivial to generate a subpackage,
> and that opofile is a desaster. Both of them are 100% correct but at
> the same time entirely miss the point.
>
> Yes, oprofile was and is a desaster, but that has aboslutely nothing to
> do with where the code lives.
>
> And yes, it's easy to generate a subpackage, but you still need all the
> source tree first. [...]
And the kernel source tree is not particularly hard to get so what's your
point? ...
> [...] There's a reason why things like X.org got split up (too fine
> grained in my opinion, but that's another story).
X.org got split up for all the wrong reasons, it's still a unified project
by and large, and the different components only work reliably when going
in lockstep so it's not like there's a true ABI between them.
So I really hope you don't advocate for that.
perf is the exact opposite: no split-up the development culture because
they are closely related, yet a relatively disciplined ABI between the
components. In fact the ABI is higher quality exactly because development
is more integrated and allows for ABI problems to be resolved before they
leak out. It also allows for faster iteration of development, without
nonsensical ABI steps pulluting the way.
> As said I very much disagree with having the userspace perf tree in the
> kernel still, but I've also given up on the fight as I have more
> important things to do.
>
> And as said before it has nothing to do with the issue discussed here
> right now.
My point is that it's a very similar meta argument: splitting up perf
usage space would be nonsensical and harmful in a similar fashion as it
would be harmful to split up the perf development space.
Put differently: there's strong benefits to having a unified perf
development environment and there's equally strong benefits on the user
side to have a unified perf usage environment that a single command
represents.
The benefits are not absolute and not unconditional, and any costs of
integration should be minimized to the best of our ability, but I hope you
get the drift of my argument ...
Thanks,
Ingo
next prev parent reply other threads:[~2013-08-12 18:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 2:22 [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable Andi Kleen
2013-08-05 8:16 ` Ingo Molnar
2013-08-05 8:23 ` Christoph Hellwig
2013-08-05 8:31 ` Ingo Molnar
2013-08-05 8:34 ` Christoph Hellwig
2013-08-05 9:08 ` Ingo Molnar
2013-08-06 6:19 ` Christoph Hellwig
2013-08-12 18:19 ` Ingo Molnar [this message]
2013-08-12 19:25 ` Vince Weaver
2013-08-13 10:48 ` Ingo Molnar
2013-08-13 12:11 ` Arnaldo Carvalho de Melo
2013-08-13 16:00 ` Ingo Molnar
2013-08-13 21:57 ` Vince Weaver
2013-08-13 22:17 ` Andi Kleen
2013-08-14 14:13 ` Arnaldo Carvalho de Melo
2013-08-14 14:20 ` Ingo Molnar
2013-08-13 14:03 ` Vince Weaver
2013-08-13 16:04 ` Ingo Molnar
2013-08-05 9:08 ` Namhyung Kim
2013-08-05 9:12 ` Ingo Molnar
2013-08-05 9:18 ` Pekka Enberg
2013-08-05 19:10 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812181956.GB19405@gmail.com \
--to=mingo@kernel.org \
--cc=acme@infradead.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox