public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [GIT PULL] tracing: final fixes for events and some
Date: Mon, 12 Aug 2013 22:39:22 -0400	[thread overview]
Message-ID: <20130813023922.GA1042@redhat.com> (raw)
In-Reply-To: <20130812181325.GA19405@gmail.com>

On Mon, Aug 12, 2013 at 08:13:25PM +0200, Ingo Molnar wrote:
 > > > I see that some of the fixes here fix issues that your earlier 
 > > > post-rc1 rounds of non-regression fixes introduced to begin with. 
 > > > That's really not a good pattern either IMO.
 > > 
 > > Not really. The earlier fixes closed some of the holes but were not good 
 > > enough. They didn't cause more regressions, but the method use to fix 
 > > the regressions it was trying to solve wasn't going to work when we saw 
 > > the extent of the regressions that had to be fixed. Oleg came up with a 
 > > better method, which meant that we had to undo the original fix, for a 
 > > even better fix.
 > 
 > My point is that _neither_ should have gone in after the merge window. 
 > -rc1 and onwards are to fix regressions caused in the merge window, full 
 > stop. Yet there was a steady stream of tracing changes in kernel/ that at 
 > best fixed ancient bugs that are only root triggerable and which nobody 
 > actually triggered all that much. Followed by fixes to the fixes.

I'm not sure why I got cc'd on this, but for my part, the perf/tracing related bugs
I've found recently may have been there for ages, but they were triggerable
as non-root users.

	Dave


  reply	other threads:[~2013-08-13  2:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 14:19 [GIT PULL] tracing: final fixes for events and some Steven Rostedt
2013-08-05 14:32 ` Ingo Molnar
2013-08-05 14:52   ` Steven Rostedt
2013-08-12 18:13     ` Ingo Molnar
2013-08-13  2:39       ` Dave Jones [this message]
2013-08-13  3:14         ` Steven Rostedt
2013-08-13 11:06           ` Ingo Molnar
2013-08-13 11:45             ` Dave Jones
2013-08-13 14:01               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813023922.GA1042@redhat.com \
    --to=davej@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox