Re: [ 00/17] 3.4.58-stable review

Guenter Roeck
2013-08-15T07:43:58Z

On 08/14/2013 11:31 PM, Greg Kroah-Hartman wrote:
> On Tue, Aug 13, 2013 at 01:19:36PM -0700, Guenter Roeck wrote:
>> I copied the individual log files for the 3.4 build to http://roeck-us.net/linux/logs
>> in case you want to browse through it.
>>
>> Here is a summary.
>>
>> mips/allmodconfig:
>> drivers/net/ethernet/3com/3c59x.c: In function 'vortex_init_one':
>> drivers/net/ethernet/3com/3c59x.c:1031:2: error: implicit declaration of function 'pci_iomap'
>>
>> We have seen that before in 3.10. Commit 78857614104 (MIPS: Expose
>> missing pci_io{map,unmap} declarations) fixes it.
>
> Now applied.
>
>> sound/oss/soundcard.c:69:31: error: 'MAX_DMA_CHANNELS' undeclared here (not in a function)
>>
>> This requires
>> d4702b189c sound: Fix make allmodconfig on MIPS
>> a62ee234a5 sound: Fix make allmodconfig on MIPS correctly
>
> Now applied.
>
>> Unfortunately, after applying those patches the build still fails with
>>
>> ERROR: "min_low_pfn" [drivers/net/wireless/ath/ath6kl/ath6kl_sdio.ko] undefined!
>>
>> This has been fixed upstream with commit 8b9232141b (MIPS: Rewrite pfn_valid to work
>> in modules, too), which applies but results in build failures.
>
> What failures? I've applied this now, as it makes sense.
>
>> There is a patch from Ben Hutchings which removes the use of
>> virt_addr_valid() (which causes the problem) from the ath6kl driver,
>> but that is not in mainline.
>
> Ok, I think I'll stop there for MIPS, that's a good start...
>

I screwed up my stable repo clone again :(, so the full build will take a bit.

mips builds on on 3.4 with all patches applied now fail with:
arch/mips/include/asm/page.h: Assembler messages:
arch/mips/include/asm/page.h:178: Error: Unrecognized opcode `static inline int pfn_valid(unsigned long pfn)'
arch/mips/include/asm/page.h:179: Error: junk at end of line, first unrecognized character is `{'
arch/mips/include/asm/page.h:181: Error: Unrecognized opcode `extern unsigned long max_mapnr'
arch/mips/include/asm/page.h:183: Error: Unrecognized opcode `return pfn>=ARCH_PFN_OFFSET&&pfn<max_mapnr'
arch/mips/include/asm/page.h:184: Error: junk at end of line, first unrecognized character is `}'

This is the error I referred to above. Reverting above pfn rework patch fixes that problem,
so you might want to remove that patch from the patch queue for now.

Guenter