Re: [ 00/17] 3.4.58-stable review

Guenter Roeck
2013-08-13T22:36:27Z

On Tue, Aug 13, 2013 at 10:49:42PM +0200, Geert Uytterhoeven wrote:
> On Tue, Aug 13, 2013 at 10:19 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > powerpc/chroma_defconfig:
> > arch/powerpc/mm/numa.c: In function 'do_init_bootmem':
> > arch/powerpc/mm/numa.c:529:19: error: 'aa.arrays' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > arch/powerpc/mm/numa.c:642:22: note: 'aa.arrays' was declared here
> > cc1: all warnings being treated as errors
> >
> > No idea. Code looks all different in 3.10.
>
> Never seen in my log collection from kissb, which doesn't build
> chroma_defconfig.
>
> > m68k/allmodconfig:
> > drivers/hid/hid-microsoft.c: In function 'ms_report_fixup':
> > drivers/hid/hid-microsoft.c:52:18: error: macro "memcmp" passed 6 arguments, but takes just 3
> > drivers/hid/hid-microsoft.c:51:5: error: 'memcmp' undeclared (first use in this function)
> > drivers/hid/hid-microsoft.c:51:5: note: each undeclared identifier is reported only once for each function it appears in
>
> Fixed in v3.7-rc6:
>
> commit 6b90466cfec2a2fe027187d675d8d14217c12d82
> Author: Jiri Slaby <jslaby@suse.cz>
> Date: Mon Nov 12 10:16:09 2012 +0100
>
> HID: microsoft: do not use compound literal - fix build
>
Confirmed. Patching this commit into 3.4 fixes the build for m68k/allmodconfig.

> > blackfin/defconfig:
> > ERROR: "vm_iomap_memory" [drivers/video/fb.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> >
> > sh/defconfig:
> > drivers/built-in.o: In function `fb_mmap':
> > fbmem.c:(.text+0x5e8): undefined reference to `vm_iomap_memory'
> >
> > Both look similar and might be easy to fix if someone knows what is wrong.
>
> Fixed in v3.9:
>
> commit 3c0b9de6d37a481673e81001c57ca0e410c72346
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Sat Apr 27 13:25:38 2013 -0700
>
> vm: add no-mmu vm_iomap_memory() stub
>
Confirmed. Patching this commit into 3.4 fixes the build for
both blackbuid/defconfig and sh/defconfig.

> > cris/...:
> > In file included from include/linux/page-flags.h:8:0,
> > from kernel/bounds.c:9:
> > include/linux/types.h:25:1: error: unknown type name '__kernel_ino_t'
> > include/linux/types.h:29:1: error: unknown type name '__kernel_off_t'
> > include/linux/types.h:30:1: error: unknown type name '__kernel_pid_t'
> > include/linux/types.h:31:1: error: unknown type name '__kernel_daddr_t'
> > include/linux/types.h:33:1: error: unknown type name '__kernel_suseconds_t'
> >
> > That one might be tricky (or simple if someone knows what is wrong).
>
> Fixed in v3.5-rc1:
>
> commit 74f077d2a7651409c44bb323471f219a4b0d2aab
> Author: Jiri Slaby <jslaby@suse.cz>
> Date: Mon Apr 2 13:40:17 2012 +0200
>
> cris: posix_types.h, include asm-generic/posix_types.h
>
It does fix above error, but then there is another error:

AS arch/cris/arch-v10/lib/checksum.o
In file included from <command-line>:4:0:
/home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
make[1]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
make[1]: *** Waiting for unfinished jobs....
AS arch/cris/arch-v10/lib/checksumcopy.o
In file included from <command-line>:4:0:
/home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
make[1]: *** [arch/cris/arch-v10/lib/checksumcopy.o] Error 1

Guenter