Re: [ 00/17] 3.4.58-stable review

Greg Kroah-Hartman
2013-08-17T00:01:14Z

On Fri, Aug 16, 2013 at 03:39:50PM -0700, Guenter Roeck wrote:
> On Fri, Aug 16, 2013 at 11:55:02PM +0200, Geert Uytterhoeven wrote:
> > On Fri, Aug 16, 2013 at 10:27 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> > > Still failing:
> > > sparc64:allmodconfig
> > > /opt/buildbot/slave/stable-queue-3_4/build/usr/include/linux/types.h:27:1: error: unknown type name ‘__u16’
> >
> > According to my log collection, this same error message was fixed in v3.3-rc2,
> > but I couldn't easily find a matching commit.
> > But this is v3.4-stable, which is after v3.3-rc2, so it got reintroduced?
> >
> It was fixed recently with
>
> commit cbf1ef6b3345d2cc7e62407eec6a6f72a8b1346f
> Author: Sam Ravnborg <sam@ravnborg.org>
> Date: Sun Mar 31 07:01:47 2013 +0000
>
> sparc: use asm-generic version of types.h
>
> and
>
> commit a2d34dd41212032c03e77bc30c2023725def841a
> Author: Sam Ravnborg <sam@ravnborg.org>
> Date: Sat Mar 30 11:44:22 2013 +0000
>
> sparc: use generic headers
>
> I tried to apply those patches, but it failed miserably due to the
> userspace/kernel header separation. Given that, I figured that
> it would be too invasive to fix, at least for me.
>
> > > xtensa:defconfig
> > > dev.c:(.text.unlikely+0x3): dangerous relocation: l32r: literal placed after use: .literal.unlikely
> >
> > Fixed in v3.7-rc1:
> >
> > commit f6a03a12ecdbe0dd80a55f6df3b7206c5a403a49
> > Author: Max Filippov <jcmvbkbc@gmail.com>
> > Date: Mon Sep 17 05:44:31 2012 +0400
> >
> > xtensa: fix linker script transformation for .text.unlikely
> >
> Yes, that fixes this problem, except now we get another known error:
>
> kernel/built-in.o:(.text+0x8c8): undefined reference to `_sdata'
>
> which you had fixed with
>
> commit 5e7b6ed8e9bf3c8e3bb579fd0aec64f6526f8c81
> Author: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Wed Jun 20 12:52:58 2012 -0700
>
> xtensa: replace xtensa-specific _f{data,text} by _s{data,text}
>
> After applying both patches to the 3.4-stable queue, xtensa:defconfig builds
> successfully.

Thanks, both now applied.

greg k-h