Re: [ 00/17] 3.4.58-stable review

Guenter Roeck
2013-08-15T08:40:15Z

On 08/14/2013 11:36 PM, Greg Kroah-Hartman wrote:
> On Wed, Aug 14, 2013 at 03:14:11AM -0700, Guenter Roeck wrote:
>> On 08/14/2013 01:26 AM, Geert Uytterhoeven wrote:
>>> On Wed, Aug 14, 2013 at 12:36 AM, Guenter Roeck <linux@roeck-us.net> wrote:
>>>>>> cris/...:
>>>>>> In file included from include/linux/page-flags.h:8:0,
>>>>>> from kernel/bounds.c:9:
>>>>>> include/linux/types.h:25:1: error: unknown type name '__kernel_ino_t'
>>>>>> include/linux/types.h:29:1: error: unknown type name '__kernel_off_t'
>>>>>> include/linux/types.h:30:1: error: unknown type name '__kernel_pid_t'
>>>>>> include/linux/types.h:31:1: error: unknown type name '__kernel_daddr_t'
>>>>>> include/linux/types.h:33:1: error: unknown type name '__kernel_suseconds_t'
>>>>>>
>>>>>> That one might be tricky (or simple if someone knows what is wrong).
>>>>>
>>>>> Fixed in v3.5-rc1:
>>>>>
>>>>> commit 74f077d2a7651409c44bb323471f219a4b0d2aab
>>>>> Author: Jiri Slaby <jslaby@suse.cz>
>>>>> Date: Mon Apr 2 13:40:17 2012 +0200
>>>>>
>>>>> cris: posix_types.h, include asm-generic/posix_types.h
>>>>>
>>>> It does fix above error, but then there is another error:
>>>>
>>>> AS arch/cris/arch-v10/lib/checksum.o
>>>> In file included from <command-line>:4:0:
>>>> /home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
>>>> make[1]: *** [arch/cris/arch-v10/lib/checksum.o] Error 1
>>>> make[1]: *** Waiting for unfinished jobs....
>>>> AS arch/cris/arch-v10/lib/checksumcopy.o
>>>> In file included from <command-line>:4:0:
>>>> /home/groeck/src/linux-stable/include/linux/kconfig.h:23:0: error: syntax error in macro parameter list
>>>> make[1]: *** [arch/cris/arch-v10/lib/checksumcopy.o] Error 1
>>>
>>> commit 7b91747d42a1012e3781dd09fa638d113809e3fd
>>> Author: Paul Gortmaker <paul.gortmaker@windriver.com>
>>> Date: Wed Apr 18 21:58:43 2012 +0200
>>>
>>> cris: Remove old legacy "-traditional" flag from arch-v10/lib/Makefile
>>>
>>
>> Great, thanks for tracking this down.
>>
>> With both patches applied, we are almost there. Next error:
>>
>> kernel/built-in.o: In function `core_kernel_data':
>> (.text+0x12e38): undefined reference to `_sdata'
>> make: *** [vmlinux] Error 1
>>
>> This has been fixed with commit 473e162e (CRIS: Add _sdata to vmlinux.lds.S).
>>
>> So, in summary, we have
>>
>> 473e162e CRIS: Add _sdata to vmlinux.lds.S

473e162e also fixes the cris builds in 3.0, so it might make sense to apply it there as well,
at least if 3.0 has some lifetime left.

Guenter