Re: [ 00/17] 3.4.58-stable review

Geert Uytterhoeven
2013-08-15T07:55:14Z

On Thu, Aug 15, 2013 at 9:43 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> I screwed up my stable repo clone again :(, so the full build will take a
> bit.
>
> mips builds on on 3.4 with all patches applied now fail with:
> arch/mips/include/asm/page.h: Assembler messages:
> arch/mips/include/asm/page.h:178: Error: Unrecognized opcode `static inline
> int pfn_valid(unsigned long pfn)'
> arch/mips/include/asm/page.h:179: Error: junk at end of line, first
> unrecognized character is `{'
> arch/mips/include/asm/page.h:181: Error: Unrecognized opcode `extern
> unsigned long max_mapnr'
> arch/mips/include/asm/page.h:183: Error: Unrecognized opcode `return
> pfn>=ARCH_PFN_OFFSET&&pfn<max_mapnr'
> arch/mips/include/asm/page.h:184: Error: junk at end of line, first
> unrecognized character is `}'
>
> This is the error I referred to above. Reverting above pfn rework patch
> fixes that problem,
> so you might want to remove that patch from the patch queue for now.

Perhaps this one got applied too soon?

commit 730b8dfe016dd1e91f73d8d3e6724da91397171c
Author: Ralf Baechle <ralf@linux-mips.org>
Date: Fri Dec 28 15:18:02 2012 +0100

MIPS: page.h: Remove now unnecessary #ifndef __ASSEMBLY__ wrapper.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds