From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Anton Vorontsov'" <anton@enomsg.org>,
"'David Woodhouse'" <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH 33/35] power: use dev_get_platdata()
Date: Tue, 13 Aug 2013 12:00:39 +0300 [thread overview]
Message-ID: <20130813090039.GA5604@mwanda> (raw)
In-Reply-To: <003401ce96f2$0f53b840$2dfb28c0$@samsung.com>
On Mon, Aug 12, 2013 at 09:22:42AM +0900, Jingoo Han wrote:
> On Saturday, August 10, 2013 7:05 AM, Anton Vorontsov wrote:
> > On Tue, Jul 30, 2013 at 05:19:27PM +0900, Jingoo Han wrote:
> > > Use the wrapper function for retrieving the platform data instead of
> > > accessing dev->platform_data directly.
> >
> > Um.. what is the benefit or rationale of this patch?
>
> CC'ed Joe Perches, Dan Carpenter
>
> Hi Anton Vorontsov,
>
> Usually, using the wrapper function makes the code simpler.
> Also, it make the code more readable.
Since people are asking my opinion, then yes using
dev_get_platdata() as intended is better than open coding. It's a
coding standard thing.
regards,
dan carpenter
next prev parent reply other threads:[~2013-08-13 9:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 8:19 [PATCH 33/35] power: use dev_get_platdata() Jingoo Han
2013-08-09 22:04 ` Anton Vorontsov
2013-08-12 0:22 ` Jingoo Han
2013-08-13 9:00 ` Dan Carpenter [this message]
2013-08-28 1:58 ` Anton Vorontsov
2013-08-28 2:19 ` Jingoo Han
2013-08-28 8:36 ` Dan Carpenter
2013-08-29 0:25 ` Jingoo Han
2013-08-29 1:18 ` Anton Vorontsov
2013-08-29 2:07 ` 'Greg Kroah-Hartman'
2013-08-29 2:18 ` Jingoo Han
2013-08-29 3:07 ` Anton Vorontsov
2013-08-29 10:41 ` Mark Brown
2013-08-29 2:14 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130813090039.GA5604@mwanda \
--to=dan.carpenter@oracle.com \
--cc=anton@enomsg.org \
--cc=dwmw2@infradead.org \
--cc=jg1.han@samsung.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox