public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Dave Jones <davej@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
	Oleg Nesterov <oleg@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [GIT PULL] tracing: final fixes for events and some
Date: Tue, 13 Aug 2013 13:06:18 +0200	[thread overview]
Message-ID: <20130813110618.GA3300@gmail.com> (raw)
In-Reply-To: <20130812231443.52563398@gandalf.local.home>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Mon, 12 Aug 2013 22:39:22 -0400
> Dave Jones <davej@redhat.com> wrote:
> 
> 
> > I'm not sure why I got cc'd on this, but for my part, the perf/tracing 
> > related bugs I've found recently may have been there for ages, but 
> > they were triggerable as non-root users.
> 
> Which bug was able to trigger with non-root? The hash one that you 
> reported? That is something with the function tracer. Are you able to 
> enable function tracing as non-root?
> 
> Or is it because you gave more permissions for non-root to use extra 
> perf commands. Because no one but root should be able to enable function 
> tracing, as that can add a large overhead to the system.

Hm, also, tracepoints should in general only be accessible to root - all 
sorts of random privileged info leaks through tracepoints, a thorough 
review and sanitizing is needed to expose that to users. (and that does 
not consider the complication caused by exposing timing info.)

Thanks,

	Ingo

  reply	other threads:[~2013-08-13 11:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 14:19 [GIT PULL] tracing: final fixes for events and some Steven Rostedt
2013-08-05 14:32 ` Ingo Molnar
2013-08-05 14:52   ` Steven Rostedt
2013-08-12 18:13     ` Ingo Molnar
2013-08-13  2:39       ` Dave Jones
2013-08-13  3:14         ` Steven Rostedt
2013-08-13 11:06           ` Ingo Molnar [this message]
2013-08-13 11:45             ` Dave Jones
2013-08-13 14:01               ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130813110618.GA3300@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=oleg@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox