From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932271Ab3HMQES (ORCPT ); Tue, 13 Aug 2013 12:04:18 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:28520 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758690Ab3HMP6e (ORCPT ); Tue, 13 Aug 2013 11:58:34 -0400 X-Authority-Analysis: v=2.0 cv=aqMw+FlV c=1 sm=0 a=Sro2XwOs0tJUSHxCKfOySw==:17 a=Drc5e87SC40A:10 a=Ciwy3NGCPMMA:10 a=eqNnmgv1MskA:10 a=5SG0PmZfjMsA:10 a=bbbx4UPp9XUA:10 a=meVymXHHAAAA:8 a=KGjhK52YXX0A:10 a=RV-77sf7uzIA:10 a=PW-KNzBFAAAA:8 a=e_4A-qIoAAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=5cIBTxRJ4pZzZk2xk6UA:9 a=YIcDdqurk5kA:10 a=0a5UCvtdz_cA:10 a=MSl-tDqOz04A:10 a=jeBq3FmKZ4MA:10 a=PEW8gS-ILaDUwi5x:21 a=QAvE7CiUl2m0MfCN:21 a=Sro2XwOs0tJUSHxCKfOySw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.255.60.225 Message-Id: <20130813155828.799509232@goodmis.org> User-Agent: quilt/0.60-1 Date: Tue, 13 Aug 2013 11:57:27 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ferruh Yigit , Javier Martinez Canillas , Dmitry Torokhov Subject: [33/88] Input: cyttsp - fix memcpy size param References: <20130813155654.069291373@goodmis.org> Content-Disposition: inline; filename=0033-Input-cyttsp-fix-memcpy-size-param.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.6.11.7-rc1 stable review patch. If anyone has any objections, please let me know. ------------------ From: Ferruh Yigit [ Upstream commit d2983cdb480157f637df07723f28aaa657b1080d ] memcpy param is wrong because of offset in bl_cmd, this may corrupt the stack which may cause a crash. Tested-by: Ferruh Yigit on TMA300-DVK Signed-off-by: Ferruh Yigit Acked-by: Javier Martinez Canillas Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Steven Rostedt --- drivers/input/touchscreen/cyttsp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c index f030d9e..3f505d5 100644 --- a/drivers/input/touchscreen/cyttsp_core.c +++ b/drivers/input/touchscreen/cyttsp_core.c @@ -133,7 +133,7 @@ static int cyttsp_exit_bl_mode(struct cyttsp *ts) memcpy(bl_cmd, bl_command, sizeof(bl_command)); if (ts->pdata->bl_keys) memcpy(&bl_cmd[sizeof(bl_command) - CY_NUM_BL_KEYS], - ts->pdata->bl_keys, sizeof(bl_command)); + ts->pdata->bl_keys, CY_NUM_BL_KEYS); error = ttsp_write_block_data(ts, CY_REG_BASE, sizeof(bl_cmd), bl_cmd); -- 1.7.10.4