From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759411Ab3HNHgC (ORCPT <rfc822;w@1wt.eu>);
	Wed, 14 Aug 2013 03:36:02 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:46493 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759088Ab3HNHgA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 14 Aug 2013 03:36:00 -0400
Date: Wed, 14 Aug 2013 00:33:36 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
        Andy Lutomirski <luto@amacapital.net>,
        Pavel Emelyanov <xemul@parallels.com>, Matt Mackall <mpm@selenic.com>,
        Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Peter Zijlstra <peterz@infradead.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH -mm] mm: Unify pte_to_pgoff and pgoff_to_pte helpers
Message-Id: <20130814003336.0fb2a275.akpm@linux-foundation.org>
In-Reply-To: <520B3240.6030208@zytor.com>
References: <20130814070059.GJ2869@moon>
	<520B303D.2090206@zytor.com>
	<20130814072453.GK2869@moon>
	<520B3240.6030208@zytor.com>
X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 14 Aug 2013 00:31:12 -0700 "H. Peter Anvin" <hpa@zytor.com> wrote:

> On 08/14/2013 12:24 AM, Cyrill Gorcunov wrote:
> > On Wed, Aug 14, 2013 at 12:22:37AM -0700, H. Peter Anvin wrote:
> >> On 08/14/2013 12:00 AM, Cyrill Gorcunov wrote:
> >>> +#define pte_bfop(v,r,m,l)	((((v) >> (r)) & (m)) << (l))
> >>
> >> "bfop"?
> > 
> > B_it_F_ield_OP_eration, Peter I don't mind to use any other
> > name, this was just short enough to type.
> > 
> 
> I think it would be useful to have a comment what it means and what
> v,r,m,l represent.

Can it be written in C with types and proper variable names and such
radical stuff?