Re: [PATCH 1/1] intel_ips: blacklist ASUSTek G60JX laptops

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Wed, 14 Aug 2013 12:22:49 -0400
Joseph Salisbury <joseph.salisbury@canonical.com> wrote:

> BugLink: http://bugs.launchpad.net/bugs/1210848
> 
> On an ASUSTek G60JX laptop, the intel_ips driver spams the log with a warning message: "ME failed to update for more than 1s, likely hung".  This ME doesn't support the feature, so requesting it be blacklisted for now.   
> 
> Signed-off-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Tested-by: Nick Jenkins <tech.crew.jenkins@gmail.com> 
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: platform-driver-x86@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> ---
>  drivers/platform/x86/intel_ips.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/intel_ips.c b/drivers/platform/x86/intel_ips.c
> index 18dcb58..6d8c5e0 100644
> --- a/drivers/platform/x86/intel_ips.c
> +++ b/drivers/platform/x86/intel_ips.c
> @@ -1501,6 +1501,14 @@ static const struct dmi_system_id ips_blacklist[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "HP ProBook"),
>  		},
>  	},
> +	{
> +		.callback = ips_blacklist_callback,
> +		.ident = "G60JX",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "G60JX"),
> +		},
> +	},
>  	{ }	/* terminating entry */
>  };
>  

Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Linus, you may want to pick this up directly, as I'm not sure if
Matthew is still looking after the x86 drivers these days.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center