* [PATCH 14/16] amd_iommu: clean up unnecessary MSI/MSI-X capability find
@ 2013-08-08 13:12 Yijing Wang
2013-08-14 10:20 ` Joerg Roedel
0 siblings, 1 reply; 2+ messages in thread
From: Yijing Wang @ 2013-08-08 13:12 UTC (permalink / raw)
To: Joerg Roedel; +Cc: Hanjun Guo, jiang.liu, Yijing Wang, iommu, linux-kernel
PCI core will initialize device MSI/MSI-X capability in
pci_msi_init_pci_dev(). So device driver should use
pci_dev->msi_cap/msix_cap to determine whether the device
support MSI/MSI-X instead of using
pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
Access to PCIe device config space again will consume more time.
Signed-off-by: Yijing Wang <wangyijing@huawei.com>
Cc: Joerg Roedel <joro@8bytes.org>
Cc: iommu@lists.linux-foundation.org
Cc: linux-kernel@vger.kernel.org
---
drivers/iommu/amd_iommu_init.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
index 7acbf35..8f798be 100644
--- a/drivers/iommu/amd_iommu_init.c
+++ b/drivers/iommu/amd_iommu_init.c
@@ -1384,7 +1384,7 @@ static int iommu_init_msi(struct amd_iommu *iommu)
if (iommu->int_enabled)
goto enable_faults;
- if (pci_find_capability(iommu->dev, PCI_CAP_ID_MSI))
+ if (iommu->dev->msi_cap)
ret = iommu_setup_msi(iommu);
else
ret = -ENODEV;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 14/16] amd_iommu: clean up unnecessary MSI/MSI-X capability find
2013-08-08 13:12 [PATCH 14/16] amd_iommu: clean up unnecessary MSI/MSI-X capability find Yijing Wang
@ 2013-08-14 10:20 ` Joerg Roedel
0 siblings, 0 replies; 2+ messages in thread
From: Joerg Roedel @ 2013-08-14 10:20 UTC (permalink / raw)
To: Yijing Wang; +Cc: Hanjun Guo, jiang.liu, iommu, linux-kernel
On Thu, Aug 08, 2013 at 09:12:36PM +0800, Yijing Wang wrote:
> PCI core will initialize device MSI/MSI-X capability in
> pci_msi_init_pci_dev(). So device driver should use
> pci_dev->msi_cap/msix_cap to determine whether the device
> support MSI/MSI-X instead of using
> pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX).
> Access to PCIe device config space again will consume more time.
>
> Signed-off-by: Yijing Wang <wangyijing@huawei.com>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-kernel@vger.kernel.org
Applied to x86/amd, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-14 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-08 13:12 [PATCH 14/16] amd_iommu: clean up unnecessary MSI/MSI-X capability find Yijing Wang
2013-08-14 10:20 ` Joerg Roedel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).