From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpuset: remove redundant checks in file write functions
Date: Wed, 14 Aug 2013 09:30:48 -0400 [thread overview]
Message-ID: <20130814133048.GC28628@htj.dyndns.org> (raw)
In-Reply-To: <520AE4FC.5090702@huawei.com>
Hello, Li.
On Wed, Aug 14, 2013 at 10:01:32AM +0800, Li Zefan wrote:
> But most controllers don't check this in those read/write functions.
> It shoudn't do any harm not checking online/offline status.
It depends on the specific controller. For controllers which make
clear distinction between online and offline states for, say,
hierarchical config propagation, it could lead to buggy behavior if
the function body afterwards assume that the current node is online.
I don't know whether this is the case for the functions converted here
but even if so the patch needs to update the description.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-08-14 13:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 1:17 [PATCH 1/2] cpuset: remove an unncessary forward declaration Li Zefan
2013-08-13 1:17 ` [PATCH 2/2] cpuset: remove redundant checks in file write functions Li Zefan
2013-08-13 2:07 ` Li Zefan
2013-08-13 15:05 ` Tejun Heo
2013-08-14 2:01 ` Li Zefan
2013-08-14 13:30 ` Tejun Heo [this message]
2013-08-16 6:48 ` Li Zefan
2013-08-13 14:53 ` [PATCH 1/2] cpuset: remove an unncessary forward declaration Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814133048.GC28628@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox