public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Vince Weaver <vince@deater.net>,
	Christoph Hellwig <hch@infradead.org>,
	Andi Kleen <andi@firstfloor.org>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>,
	Namhyung Kim <namhyung.kim@lge.com>,
	peterz@infradead.org, Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable
Date: Wed, 14 Aug 2013 16:20:41 +0200	[thread overview]
Message-ID: <20130814142041.GA16087@gmail.com> (raw)
In-Reply-To: <20130814141301.GA2138@ghostprotocols.net>


* Arnaldo Carvalho de Melo <acme@ghostprotocols.net> wrote:

> Em Tue, Aug 13, 2013 at 05:57:16PM -0400, Vince Weaver escreveu:
> > On Tue, 13 Aug 2013, Ingo Molnar wrote:
> >
> > > that can only be addressed by either extending 'perf test' or by 
> > > testing libpfm et al sooner. The upstream kernel can only address 
> > > regressions that get reported.
>  
> > Most of the tests in my test-suite are reactive.  Meaning, I wrote 
> > them after an ABI-breaking change was reported elsewhere, and I needed 
> > a small test case for bisection purposes.  Thus they are good for 
> > finding if a corner of the perf ABI re-breaks but they're not great at 
> > spotting new breakages.

Would be nice to merge those in into 'perf test' - reactive tests are 
useful as well IMO.

> > Writing a complete test suite for something as complicated as the 
> > perf-event ABI is impractical.  One thing you can do is require anyone 
> > submitting new functionality also provide a regression test, but
> 
> Agreed.
> 
> > I don't see that happening.
> 
> See some of Namhyung, Adrian and Jiri recent patchsets, they came with 
> 'perf test' regression tests.

That's good progress indeed! If we merge in the cases that Vince found 
then we'd have good practical coverage and we could also start requiring 
good testcases for every new ABI extension.

That method distributes the overhead of having to write it to those who 
want to extend (and, statistically speaking, inadvertantlybreak!) the ABI.

Thanks,

	Ingo

  reply	other threads:[~2013-08-14 14:20 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05  2:22 [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable Andi Kleen
2013-08-05  8:16 ` Ingo Molnar
2013-08-05  8:23   ` Christoph Hellwig
2013-08-05  8:31     ` Ingo Molnar
2013-08-05  8:34       ` Christoph Hellwig
2013-08-05  9:08         ` Ingo Molnar
2013-08-06  6:19           ` Christoph Hellwig
2013-08-12 18:19             ` Ingo Molnar
2013-08-12 19:25               ` Vince Weaver
2013-08-13 10:48                 ` Ingo Molnar
2013-08-13 12:11                   ` Arnaldo Carvalho de Melo
2013-08-13 16:00                     ` Ingo Molnar
2013-08-13 21:57                       ` Vince Weaver
2013-08-13 22:17                         ` Andi Kleen
2013-08-14 14:13                         ` Arnaldo Carvalho de Melo
2013-08-14 14:20                           ` Ingo Molnar [this message]
2013-08-13 14:03                   ` Vince Weaver
2013-08-13 16:04                     ` Ingo Molnar
2013-08-05  9:08     ` Namhyung Kim
2013-08-05  9:12       ` Ingo Molnar
2013-08-05  9:18         ` Pekka Enberg
2013-08-05 19:10       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814142041.GA16087@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=peterz@infradead.org \
    --cc=vince@deater.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox