From: Mark Brown <broonie@kernel.org>
To: Florian Lobmaier <florian.lobmaier@ams.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com,
lee.jones@linaro.org
Subject: Re: [PATCH 2/4] added regmap of AS3722
Date: Wed, 14 Aug 2013 16:29:40 +0100 [thread overview]
Message-ID: <20130814152940.GT6427@sirena.org.uk> (raw)
In-Reply-To: <1376492098-15672-2-git-send-email-florian.lobmaier@ams.com>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Wed, Aug 14, 2013 at 04:54:56PM +0200, Florian Lobmaier wrote:
> +static bool as3722_readable(struct device *dev, unsigned int reg)
> +{
> + switch (reg) {
> + case AS3722_SD0_VOLTAGE_REG:
Are there any gaps in this register map? If not just checking the range
would be easier (it looks like this is the case here).
> + case AS3722_INTERRUPTSTATUS1_REG:
> + case AS3722_INTERRUPTSTATUS2_REG:
> + case AS3722_INTERRUPTSTATUS3_REG:
> + case AS3722_INTERRUPTSTATUS4_REG:
> +static bool as3722_volatile(struct device *dev, unsigned int reg)
> +{
> + return false;
> +}
At least the interrupt status register above should be volatile
otherwise you'll never be able to read the actual stauts.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-14 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 14:54 [PATCH 1/4] added support for ams AS3722 PMIC in mfd Florian Lobmaier
2013-08-14 14:54 ` [PATCH 2/4] added regmap of AS3722 Florian Lobmaier
2013-08-14 15:29 ` Mark Brown [this message]
2013-08-14 14:54 ` [PATCH 3/4] added AS3722 platform include file Florian Lobmaier
2013-08-14 14:54 ` [PATCH 4/4] added ams AS3722 register " Florian Lobmaier
2013-08-14 15:33 ` Lee Jones
2013-08-14 15:27 ` [PATCH 1/4] added support for ams AS3722 PMIC in mfd Lee Jones
2013-08-14 15:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814152940.GT6427@sirena.org.uk \
--to=broonie@kernel.org \
--cc=florian.lobmaier@ams.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox