From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume
Date: Wed, 14 Aug 2013 19:00:29 +0100 [thread overview]
Message-ID: <20130814180029.GK4046@lee--X1> (raw)
In-Reply-To: <CACRpkdavPSV9Lz_drJFxuoLMAv9+UAqTzudNYoQT-CK+2sivAg@mail.gmail.com>
On Wed, 14 Aug 2013, Linus Walleij wrote:
> On Fri, Aug 2, 2013 at 7:20 AM, Jingoo Han <jg1.han@samsung.com> wrote:
>
> > Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions
> > to fix the build warnings when CONFIG_PM_RUNTIME is not selected.
> > This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS
> > are only used when the CONFIG_PM_RUNTIME is enabled.
> >
> > drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function]
> > drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function]
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied the Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-08-14 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 5:20 [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume Jingoo Han
2013-08-02 10:17 ` Lee Jones
2013-08-14 16:45 ` Linus Walleij
2013-08-14 18:00 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814180029.GK4046@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox