public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	tobetter@gmail.com, broonie@linaro.org, patches@linaro.org
Subject: Re: [PATCH] usb: misc: usb3503: Force late initialization
Date: Wed, 14 Aug 2013 11:22:39 -0700	[thread overview]
Message-ID: <20130814182239.GC23847@kroah.com> (raw)
In-Reply-To: <1376476171-19072-1-git-send-email-tushar.behera@linaro.org>

On Wed, Aug 14, 2013 at 03:59:31PM +0530, Tushar Behera wrote:
> USB3503 chip needs to be reset after the USB PHY controller has been
> intiliazed, otherwise it is not detected as plugged in.

Why not?

> Currently there is no other way to ensure that USB3503 chip is probed
> after the USB PHY has been initialized, hence the last resort.

Are you sure that deferred probing doesn't solve this issue?

> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> ---
>  drivers/usb/misc/usb3503.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb/misc/usb3503.c
> index a31641e..ad8368d 100644
> --- a/drivers/usb/misc/usb3503.c
> +++ b/drivers/usb/misc/usb3503.c
> @@ -339,7 +339,7 @@ static int __init usb3503_init(void)
>  
>  	return 0;
>  }
> -module_init(usb3503_init);
> +late_initcall(usb3503_init);

I really hate stuff like this, that is what the change to the driver
core for the deferred probe work was for, could you please look into
that instead?

thanks,

greg k-h

  reply	other threads:[~2013-08-14 18:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14 10:29 [PATCH] usb: misc: usb3503: Force late initialization Tushar Behera
2013-08-14 18:22 ` Greg KH [this message]
2013-08-14 19:04   ` Mark Brown
2013-08-14 19:15     ` Greg KH
2013-08-14 19:39       ` Mark Brown
2013-08-14 19:47         ` Greg KH
2013-08-14 23:22           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814182239.GC23847@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=broonie@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=tobetter@gmail.com \
    --cc=tushar.behera@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox