public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Rui Xiang <rui.xiang@huawei.com>
Cc: Andy Lutomirski <luto@amacapital.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] userns: initialize the depth of user_namespace chain
Date: Wed, 14 Aug 2013 20:43:52 +0200	[thread overview]
Message-ID: <20130814184352.GA6381@redhat.com> (raw)
In-Reply-To: <520B2768.1090001@huawei.com>

On 08/14, Rui Xiang wrote:
>
> On 2013/8/14 13:06, Andy Lutomirski wrote:
> > On Tue, Aug 13, 2013 at 10:04 PM, Rui Xiang <rui.xiang@huawei.com> wrote:
> >> The level of init_user_ns shoule be 1.
> >
> > What's wrong with zero?
> >
>
> No problem. It is just consistent with commit 8742f229b63, IMHO.

Well, I am fine either way,

> but the initialization of level should be necessary.

but it is not necessary. This is just an "arbitrary" limit for now,
32 non-root namespaces. Perhaps we should count init_user_ns too.

Hmm. but I just realized that "> 32" in create_user_ns() should be
">= 32" in this case.

Oleg.


  reply	other threads:[~2013-08-14 18:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-14  5:04 [PATCH] userns: initialize the depth of user_namespace chain Rui Xiang
2013-08-14  5:06 ` Andy Lutomirski
2013-08-14  6:44   ` Rui Xiang
2013-08-14 18:43     ` Oleg Nesterov [this message]
2013-08-15  1:50       ` Rui Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130814184352.GA6381@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=rui.xiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox