From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Rusk <Mark.Rusk@hp.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected
Date: Wed, 14 Aug 2013 12:17:40 -0700 [thread overview]
Message-ID: <20130814191740.GA25559@kroah.com> (raw)
In-Reply-To: <1376404333-33815-1-git-send-email-Mark.Rusk@hp.com>
On Tue, Aug 13, 2013 at 09:32:13AM -0500, Mark Rusk wrote:
> Using an uninitialized variable 'devnum' after 'goto out;' was causing
> panic. Just go ahead and return, we need to ignore AUX iLO devs.
>
> Oops: 0002 [#1] SMP
> .
> .
> .
> RIP [<ffffffffa033e270>] ilo_probe+0xec/0xe7c [hpilo]
> ---
> drivers/misc/hpilo.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
I think you forgot to run this patch through the checkpatch.pl tool
before you sent it out, right (hint, no signed-off-by line...)
Please fix it up and resend, so that it can be applied...
greg k-h
next prev parent reply other threads:[~2013-08-14 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 14:32 [PATCH] drivers/misc/hpilo: Correct panic when an AUX iLO is detected Mark Rusk
2013-08-14 19:17 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-14 20:30 Mark Rusk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814191740.GA25559@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Mark.Rusk@hp.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox