From: Wolfram Sang <wsa@the-dreams.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, marex@denx.de
Subject: Re: [PATCH] i2c: mxs: Better error handling
Date: Thu, 15 Aug 2013 12:03:31 +0200 [thread overview]
Message-ID: <20130815100331.GD2987@katana> (raw)
In-Reply-To: <1372841962-26310-1-git-send-email-alexandre.belloni@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Wed, Jul 03, 2013 at 10:59:22AM +0200, Alexandre Belloni wrote:
> This patch fixes two error handling cases in mxs_i2c_xfer_msg():
>
> - in PIO mode, mxs_i2c_pio_setup_xfer() may return an error but i2c->cmd_err
> will not be set so mxs_i2c_xfer_msg() fails silently.
>
> - in DMA mode, mxs_i2c_dma_setup_xfer() may return an error and have
> i2c->cmd_err set to -ENXIO. In that case, we want to go through the
> MXS_I2C_CTRL1_CLR_GOT_A_NAK before returning.
A short explanation why we want that would be perfect.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
I'd like to postpone this until I applied Marek's PIO rework. Could you
respin after that?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-15 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-03 8:59 [PATCH] i2c: mxs: Better error handling Alexandre Belloni
2013-08-15 10:03 ` Wolfram Sang [this message]
2013-08-15 11:09 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815100331.GD2987@katana \
--to=wsa@the-dreams.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox