From: Peter Zijlstra <peterz@infradead.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, ak@linux.intel.com,
acme@redhat.com, jolsa@redhat.com, namhyung.kim@lge.com,
dsahern@gmail.com
Subject: Re: [PATCH v1 1/2] perf: add attr->mmap2 attribute to an event
Date: Thu, 15 Aug 2013 12:26:20 +0200 [thread overview]
Message-ID: <20130815102620.GN24092@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1376394957-31691-2-git-send-email-eranian@google.com>
On Tue, Aug 13, 2013 at 01:55:56PM +0200, Stephane Eranian wrote:
> @@ -638,6 +639,25 @@ enum perf_event_type {
> */
> PERF_RECORD_SAMPLE = 9,
>
> + /*
> + * The MMAP2 records are an augmented version of MMAP, they add
> + * maj, min, ino numbers to be used to uniquely identify each mapping
> + *
> + * struct {
> + * struct perf_event_header header;
> + *
> + * u32 pid, tid;
> + * u64 addr;
> + * u64 len;
> + * u64 pgoff;
> + * u32 maj;
> + * u32 min;
> + * u64 ino;
> + * char filename[];
Did you forget the sample_id stuff?
struct sample_id sample_id;
> + * };
> + */
> + PERF_RECORD_MMAP2 = 10,
> +
> PERF_RECORD_MAX, /* non-ABI */
> };
next prev parent reply other threads:[~2013-08-15 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:55 [PATCH v1 0/2] perf: add new PERF_RECORD_MMAP2 record type Stephane Eranian
2013-08-13 11:55 ` [PATCH v1 1/2] perf: add attr->mmap2 attribute to an event Stephane Eranian
2013-08-15 10:26 ` Peter Zijlstra [this message]
2013-08-19 9:14 ` Stephane Eranian
2013-08-21 9:56 ` Stephane Eranian
2013-08-21 9:55 ` Stephane Eranian
2013-08-13 11:55 ` [PATCH v1 2/2] perf tools: add attr->mmap2 support Stephane Eranian
2013-08-13 23:34 ` Andi Kleen
2013-08-14 10:30 ` Stephane Eranian
2013-08-14 16:43 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815102620.GN24092@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox