From: Andi Kleen <andi@firstfloor.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
linux-kernel@vger.kernel.org,
Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 1/2] perf x86: Make intel_pmu_enable_all to enable only active events
Date: Thu, 15 Aug 2013 15:53:14 +0200 [thread overview]
Message-ID: <20130815135314.GE19750@two.firstfloor.org> (raw)
In-Reply-To: <20130815114040.GR24092@twins.programming.kicks-ass.net>
>
> I think its a NOP; this is the global ctrl register but
> intel_pmu_disable_event() writes PERFEVTSELx.EN = 0, so even if you
> enable it in the global mask, the event should still be disabled.
Yes the hardware ANDs the various enable bits in the different
registers.
-andi
next prev parent reply other threads:[~2013-08-15 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 16:39 [RFC 0/2] perf: Fixing throttling related WARN Jiri Olsa
2013-08-13 16:39 ` [PATCH 1/2] perf x86: Make intel_pmu_enable_all to enable only active events Jiri Olsa
2013-08-15 11:40 ` Peter Zijlstra
2013-08-15 11:49 ` Jiri Olsa
2013-08-15 13:53 ` Andi Kleen [this message]
2013-08-19 9:16 ` Stephane Eranian
2013-08-19 11:16 ` Jiri Olsa
2013-08-19 14:31 ` Stephane Eranian
2013-08-19 14:45 ` Peter Zijlstra
2013-08-13 16:39 ` [PATCH 2/2] perf: Move throtling flag to perf_event_context Jiri Olsa
2013-08-15 12:12 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815135314.GE19750@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox