From: Andrew Morton <akpm@linux-foundation.org>
To: Sergei Trofimovich <slyfox@gentoo.org>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v2] Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default
Date: Thu, 15 Aug 2013 14:18:48 -0700 [thread overview]
Message-ID: <20130815141848.0af8cc27fa852905a35b02f8@linux-foundation.org> (raw)
In-Reply-To: <1376591851-31854-1-git-send-email-slyfox@gentoo.org>
On Thu, 15 Aug 2013 21:37:31 +0300 Sergei Trofimovich <slyfox@gentoo.org> wrote:
> The common error type found in forward-ported/backported patches is missing headers.
> One recent example (files and function names are mangled):
>
> void foo(){}
> EXPORT_SYMBOL(foo);
>
> gave only warning
>
> foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> void foo(){}
> ^
>
> foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default]
> EXPORT_SYMBOL(foo);
> foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int]
>
> Now it's a fata error. Tested on x86_64 allyesconfig.
Yes, let's try that.
Partly because the build still generates far too many warnings..
next prev parent reply other threads:[~2013-08-15 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-15 18:37 [PATCH v2] Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default Sergei Trofimovich
2013-08-15 21:18 ` Andrew Morton [this message]
2013-08-23 12:18 ` Geert Uytterhoeven
2013-08-23 17:37 ` Sergei Trofimovich
2013-08-23 17:55 ` [PATCH v3] " Sergei Trofimovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815141848.0af8cc27fa852905a35b02f8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox