From: Peter Zijlstra <peterz@infradead.org>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
Paul Turner <pjt@google.com>, Alex Shi <alex.shi@intel.com>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Morten Rasmussen <morten.rasmussen@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Joonsoo Kim <js1304@gmail.com>
Subject: Re: [PATCH v3 3/3] sched: clean-up struct sd_lb_stat
Date: Thu, 15 Aug 2013 20:05:21 +0200 [thread overview]
Message-ID: <20130815180521.GV24092@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1375778203-31343-4-git-send-email-iamjoonsoo.kim@lge.com>
On Tue, Aug 06, 2013 at 05:36:43PM +0900, Joonsoo Kim wrote:
> - if (sds->group_imb) {
> - sds->busiest_load_per_task =
> - min(sds->busiest_load_per_task, sds->avg_load);
> + if (busiest->group_imb) {
> + busiest->load_per_task =
> + min(busiest->load_per_task, sds->sd_avg_load);
> }
> - if (sds->max_load < sds->avg_load) {
> + if (busiest->avg_load < this->avg_load) {
Tsk, inconsistency there.
> - max_pull = min(sds->max_load - sds->avg_load, load_above_capacity);
> + max_pull = min(busiest->avg_load - sds->sd_avg_load,
> + load_above_capacity);
you just made it possible for the above subtraction to become negative.
Also not entirely sure why you renamed sds->avg_load; renaming it back.
next prev parent reply other threads:[~2013-08-15 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 8:36 [PATCH v3 0/3] optimization, clean-up about fair.c Joonsoo Kim
2013-08-06 8:36 ` [PATCH v3 1/3] sched: remove one division operation in find_buiest_queue() Joonsoo Kim
2013-09-02 7:40 ` [tip:sched/core] sched: Remove one division operation in find_busiest_queue() tip-bot for Joonsoo Kim
2013-08-06 8:36 ` [PATCH v3 2/3] sched: factor out code to should_we_balance() Joonsoo Kim
2013-08-15 11:19 ` Peter Zijlstra
2013-08-16 16:52 ` JoonSoo Kim
2013-08-15 12:34 ` Peter Zijlstra
2013-08-16 16:57 ` JoonSoo Kim
2013-09-02 7:40 ` [tip:sched/core] sched: Factor " tip-bot for Joonsoo Kim
2013-08-06 8:36 ` [PATCH v3 3/3] sched: clean-up struct sd_lb_stat Joonsoo Kim
2013-08-15 11:09 ` Peter Zijlstra
2013-08-15 11:14 ` Peter Zijlstra
2013-08-16 17:07 ` JoonSoo Kim
2013-08-15 18:05 ` Peter Zijlstra [this message]
2013-08-16 17:09 ` JoonSoo Kim
2013-09-02 7:40 ` [tip:sched/core] sched: Clean-up " tip-bot for Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130815180521.GV24092@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.shi@intel.com \
--cc=efault@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox