public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Iker Pedrosa <ikerpedrosam@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: gregkh@linuxfoundation.org, justinmattock@gmail.com,
	mujeeb.adil@gmail.com, harsh1kumar@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep
Date: Fri, 16 Aug 2013 13:41:25 +0200	[thread overview]
Message-ID: <20130816134125.c1afc15faee7ee277ff8eeb7@gmail.com> (raw)
In-Reply-To: <20130812100510.GA21492@amd.pavel.ucw.cz>

According to Documentation/timers/timers-howto.txt it is not recommended to use msleep for 1ms - 20ms because it may sleep longer than 20ms. So, it is recommended to use usleep instead.

On Mon, 12 Aug 2013 12:05:10 +0200
Pavel Machek <pavel@ucw.cz> wrote:

> On Mon 2013-08-05 11:58:27, Iker Pedrosa wrote:
> > Changed sleep function from msleep to usleep according to the documentation.
> > 
> > Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
> 
> Can you explain why this is good idea?
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


-- 
Regards,

Iker Pedrosa <ikerpedrosam@gmail.com>

  reply	other threads:[~2013-08-16 11:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05  9:58 [PATCH 0/6] Staging: winbond: Fixed some coding style issues Iker Pedrosa
2013-08-05  9:58 ` [PATCH 1/6] Staging: winbond: wb35reg: changed sleep function from msleep to usleep Iker Pedrosa
2013-08-12 10:05   ` Pavel Machek
2013-08-16 11:41     ` Iker Pedrosa [this message]
2013-08-05  9:58 ` [PATCH 2/6] Staging: winbond: wb35reg: white space deleted Iker Pedrosa
2013-08-12 10:05   ` Pavel Machek
2013-08-05  9:58 ` [PATCH 3/6] Staging: winbond: wb35reg: avoided use of extern function Iker Pedrosa
2013-08-12 10:05   ` Pavel Machek
2013-08-05  9:58 ` [PATCH 4/6] Staging: winbond: mds: fixed some lines over 80 characters Iker Pedrosa
2013-08-12 10:06   ` Pavel Machek
2013-08-05  9:58 ` [PATCH 5/6] Staging: winbond: mds_f: fixed " Iker Pedrosa
2013-08-12 10:06   ` Pavel Machek
2013-08-05  9:58 ` [PATCH 6/6] Staging: winbond: mds_f: deleted extern function Iker Pedrosa
2013-08-12 10:07   ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130816134125.c1afc15faee7ee277ff8eeb7@gmail.com \
    --to=ikerpedrosam@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=harsh1kumar@gmail.com \
    --cc=justinmattock@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mujeeb.adil@gmail.com \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox