From: Greg KH <gregkh@linuxfoundation.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: mingo@redhat.com, hpa@linux.intel.com, tglx@linutronix.de,
benh@kernel.crashing.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
rjw@sisk.pl, fenghua.yu@intel.com, bp@suse.de,
srivatsa.bhat@linux.vnet.ibm.com, isimatu.yasuaki@jp.fujitsu.com
Subject: Re: [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places
Date: Sat, 17 Aug 2013 16:15:52 -0700 [thread overview]
Message-ID: <20130817231552.GA20169@kroah.com> (raw)
In-Reply-To: <1376768819-28975-3-git-send-email-toshi.kani@hp.com>
On Sat, Aug 17, 2013 at 01:46:57PM -0600, Toshi Kani wrote:
> lock_device_hotplug() serializes CPU & Memory online/offline and hotplug
> operations. However, this lock is not held in the debug interfaces below
> that initiate CPU online/offline operations.
>
> - _debug_hotplug_cpu(), cpu0 hotplug test interface enabled by
> CONFIG_DEBUG_HOTPLUG_CPU0.
> - cpu_probe_store() and cpu_release_store(), cpu hotplug test interface
> enabled by CONFIG_ARCH_CPU_PROBE_RELEASE.
>
> This patch changes the above interfaces to hold lock_device_hotplug().
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> ---
> arch/x86/kernel/topology.c | 2 ++
> drivers/base/cpu.c | 16 ++++++++++++++--
> 2 files changed, 16 insertions(+), 2 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2013-08-17 23:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 19:46 [PATCH 0/4] Unify CPU hotplug lock interface Toshi Kani
2013-08-17 19:46 ` [PATCH 1/4] hotplug, x86: Fix online state in cpu0 debug interface Toshi Kani
2013-08-18 0:59 ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 2/4] hotplug, x86: Add hotplug lock to missing places Toshi Kani
2013-08-17 23:15 ` Greg KH [this message]
2013-08-19 14:53 ` Toshi Kani
2013-08-18 0:59 ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 3/4] hotplug, x86: Disable ARCH_CPU_PROBE_RELEASE on x86 Toshi Kani
2013-08-18 1:00 ` Rafael J. Wysocki
2013-08-17 19:46 ` [PATCH 4/4] hotplug, powerpc, x86: Remove cpu_hotplug_driver_lock() Toshi Kani
2013-08-18 1:01 ` Rafael J. Wysocki
2013-08-19 15:20 ` Nathan Fontenot
2013-08-19 15:23 ` Toshi Kani
2013-08-18 1:02 ` [PATCH 0/4] Unify CPU hotplug lock interface Rafael J. Wysocki
2013-08-19 14:54 ` Toshi Kani
2013-08-29 17:15 ` Toshi Kani
2013-08-30 0:06 ` Rafael J. Wysocki
2013-08-30 0:12 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130817231552.GA20169@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=benh@kernel.crashing.org \
--cc=bp@suse.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@linux.intel.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox