From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754962Ab3HRDLa (ORCPT ); Sat, 17 Aug 2013 23:11:30 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:37147 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753864Ab3HRDL3 (ORCPT ); Sat, 17 Aug 2013 23:11:29 -0400 X-Originating-IP: 50.43.39.152 Date: Sat, 17 Aug 2013 20:11:20 -0700 From: Josh Triplett To: "Paul E. McKenney" Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, darren@dvhart.com, fweisbec@gmail.com, sbw@mit.edu Subject: Re: [PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle arguments to API Message-ID: <20130818031120.GJ28923@leaf> References: <20130818014918.GA27827@linux.vnet.ibm.com> <1376790584-28120-1-git-send-email-paulmck@linux.vnet.ibm.com> <1376790584-28120-7-git-send-email-paulmck@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376790584-28120-7-git-send-email-paulmck@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 17, 2013 at 06:49:42PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds an isidle and jiffies argument to force_qs_rnp(), > dyntick_save_progress_counter(), and rcu_implicit_dynticks_qs() to enable > RCU's force-quiescent-state process to check for full-system idle. > > Signed-off-by: Paul E. McKenney > Cc: Frederic Weisbecker > Cc: Steven Rostedt > Cc: Lai Jiangshan > [ paulmck: Use true and false for boolean constants per Lai Jiangshan. ] One optional comment below; with or without that, Reviewed-by: Josh Triplett > kernel/rcutree.c | 23 ++++++++++++++++------- > 1 file changed, 16 insertions(+), 7 deletions(-) > > diff --git a/kernel/rcutree.c b/kernel/rcutree.c > index b0d2cc3..f1a0b05 100644 > --- a/kernel/rcutree.c > +++ b/kernel/rcutree.c > @@ -246,7 +246,9 @@ module_param(jiffies_till_next_fqs, ulong, 0644); > > static void rcu_start_gp_advanced(struct rcu_state *rsp, struct rcu_node *rnp, > struct rcu_data *rdp); > -static void force_qs_rnp(struct rcu_state *rsp, int (*f)(struct rcu_data *)); > +static void force_qs_rnp(struct rcu_state *rsp, > + int (*f)(struct rcu_data *, bool *, unsigned long *), > + bool *isidle, unsigned long *maxj); You might consider giving the parameters of the function pointer names (both here and in the definition), to make it more self-documenting. - Josh Triplett