From: "Pali Rohár" <pali.rohar@gmail.com>
To: Ben Skeggs <bskeggs@redhat.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
David Airlie <airlied@linux.ie>,
Martin Peres <martin.peres@labri.fr>
Subject: Re: [PATCH] nouveau: fix reclocking on nv40
Date: Mon, 19 Aug 2013 08:59:32 +0200 [thread overview]
Message-ID: <201308190859.32696@pali> (raw)
In-Reply-To: <1376657827-8105-1-git-send-email-pali.rohar@gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 1133 bytes --]
On Friday 16 August 2013 14:57:07 Pali Rohár wrote:
> In commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was
> introduced error which cause that reclocking on nv40 not
> working anymore. There is missing assigment of return value
> from pll_calc to ret.
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Martin Peres <martin.peres@labri.fr>
> ---
> drivers/gpu/drm/nouveau/nv40_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nv40_pm.c
> b/drivers/gpu/drm/nouveau/nv40_pm.c index 3af5bcd..625f80d
> 100644
> --- a/drivers/gpu/drm/nouveau/nv40_pm.c
> +++ b/drivers/gpu/drm/nouveau/nv40_pm.c
> @@ -131,7 +131,7 @@ nv40_calc_pll(struct drm_device *dev, u32
> reg, struct nvbios_pll *pll, if (clk < pll->vco1.max_freq)
> pll->vco2.max_freq = 0;
>
> - pclk->pll_calc(pclk, pll, clk, &coef);
> + ret = pclk->pll_calc(pclk, pll, clk, &coef);
> if (ret == 0)
> return -ERANGE;
Hello, it is possible to include this patch in 3.11?
Or it is too late now and need to wait for 3.12?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-08-19 6:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 9:28 [PATCH] nouveau reclocking on nv40 not working since 77145f1cbdf8d28b46ff8070ca749bad821e0774 Pali Rohár
2013-08-15 17:46 ` Pali Rohár
2013-08-15 22:23 ` Martin Peres
2013-08-16 7:16 ` Pali Rohár
2013-08-16 10:23 ` Martin Peres
2013-08-16 12:57 ` [PATCH] nouveau: fix reclocking on nv40 Pali Rohár
2013-08-19 6:59 ` Pali Rohár [this message]
2013-08-21 0:24 ` Ben Skeggs
2013-09-08 11:25 ` Pali Rohár
2013-09-09 4:28 ` Ben Skeggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201308190859.32696@pali \
--to=pali.rohar@gmail.com \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.peres@labri.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox