From: Mike Snitzer <snitzer@redhat.com>
To: Frank Mayhar <fmayhar@google.com>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com
Subject: Re: dm: Make MIN_IOS, et al, tunable via sysctl.
Date: Mon, 19 Aug 2013 09:40:39 -0400 [thread overview]
Message-ID: <20130819134038.GA27167@redhat.com> (raw)
In-Reply-To: <20130817123039.GR1762@agk-dp.fab.redhat.com>
On Sat, Aug 17 2013 at 8:30am -0400,
Alasdair G Kergon <agk@redhat.com> wrote:
> On Fri, Aug 16, 2013 at 03:55:21PM -0700, Frank Mayhar wrote:
> > This patch fixes that by changing the hardcoded MIN_IOS (and certain
> > other) #defines in dm-crypt, dm-io, dm-mpath, dm-snap and dm itself to
> > sysctl-modifiable values. This lets us change the size of these pools
> > on the fly, we can reduce the size of the pools and reduce memory
> > pressure.
>
> Did you consider using module_param_named()?
> (E.g. dm_verity_prefetch_cluster in dm-verity.)
Right, I'd prefer to see this be implemented in terms of
module_param_named(). Aside from dm-verity, dm-bufio.c makes the most
use of it.
Mike
next prev parent reply other threads:[~2013-08-19 13:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 17:48 [PATCH] dm: Make MIN_IOS, et al, tunable via sysctl Frank Mayhar
2013-08-13 16:41 ` Frank Mayhar
2013-08-16 22:58 ` Frank Mayhar
2013-08-17 12:30 ` [dm-devel] " Alasdair G Kergon
2013-08-19 13:40 ` Mike Snitzer [this message]
2013-08-19 15:04 ` Frank Mayhar
2013-08-19 14:00 ` Mike Snitzer
2013-08-19 17:54 ` [dm-devel] " Frank Mayhar
2013-08-19 18:15 ` Mike Snitzer
2013-08-20 21:44 ` [dm-devel] " Mikulas Patocka
2013-08-20 21:52 ` Frank Mayhar
2013-08-20 21:41 ` Mikulas Patocka
2013-08-20 21:22 ` [dm-devel] [PATCH] " Mikulas Patocka
2013-08-20 21:28 ` Frank Mayhar
2013-08-20 21:47 ` Mikulas Patocka
2013-08-20 21:57 ` Frank Mayhar
2013-08-20 22:24 ` Mike Snitzer
2013-08-20 22:52 ` Mikulas Patocka
2013-08-20 23:14 ` Frank Mayhar
2013-08-26 14:28 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819134038.GA27167@redhat.com \
--to=snitzer@redhat.com \
--cc=dm-devel@redhat.com \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).