From: Oleg Nesterov <oleg@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
Brad Spengler <spender@grsecurity.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Colin Walters <walters@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH? fix unshare(NEWPID) && vfork()
Date: Mon, 19 Aug 2013 19:51:24 +0200 [thread overview]
Message-ID: <20130819175124.GA23167@redhat.com> (raw)
In-Reply-To: <CA+55aFzTr7zm2uyZOxMA8wP3FoKPtk__kgGBqf7peMW2Ov8KJA@mail.gmail.com>
On 08/19, Linus Torvalds wrote:
>
> So I think your patch is correct, although I'm not sure why you move
> the test.
I didn't really, we have 2 tests, in do_fork() and copy_process().
I think it would be better to do the similar checks in one place.
This is off-topic and needs a separate change anyway, but perhaps
we should add the new helper which checks clone_flags. copy_process()
is huge.
> The new test you have look complicated as hell, so I think
> you're actually making things worse by making them unreadable.
Oh I agree. I'll wait for the comments on intent, then try to
cleanup it somehow. Unless a better fix comes.
Oleg.
next prev parent reply other threads:[~2013-08-19 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 17:25 PATCH? fix unshare(NEWPID) && vfork() Oleg Nesterov
2013-08-19 17:46 ` Linus Torvalds
2013-08-19 17:51 ` Oleg Nesterov [this message]
2013-08-19 18:10 ` Andy Lutomirski
2013-08-19 18:33 ` Oleg Nesterov
2013-08-19 18:40 ` Andy Lutomirski
2013-08-19 18:43 ` Oleg Nesterov
2013-08-20 17:55 ` Eric W. Biederman
2013-08-20 18:45 ` Oleg Nesterov
2013-08-20 20:52 ` Eric W. Biederman
2013-08-21 16:35 ` Oleg Nesterov
2013-08-22 16:47 ` Oleg Nesterov
2013-08-20 17:59 ` Andy Lutomirski
2013-08-20 18:50 ` Oleg Nesterov
2013-08-20 19:00 ` Andy Lutomirski
2013-08-20 19:05 ` Oleg Nesterov
2013-08-20 19:13 ` Andy Lutomirski
2013-08-20 19:23 ` Oleg Nesterov
2013-08-20 19:38 ` Andy Lutomirski
2013-08-21 12:24 ` Oleg Nesterov
2013-08-20 20:25 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130819175124.GA23167@redhat.com \
--to=oleg@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=spender@grsecurity.net \
--cc=torvalds@linux-foundation.org \
--cc=walters@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).