From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, David Brown <davidb@codeaurora.org>,
Daniel Walker <dwalker@fifo99.com>,
Bryan Huntsman <bryanh@codeaurora.org>
Subject: Re: [PATCH 1/3] mfd: pm8921: include missing linux/module.h
Date: Tue, 20 Aug 2013 08:28:44 +0100 [thread overview]
Message-ID: <20130820072844.GF23699@lee--X1> (raw)
In-Reply-To: <005201ce9d73$1696e230$43c4a690$@samsung.com>
On Tue, 20 Aug 2013, Jingoo Han wrote:
> Include <linux/module.h> in order to fix the following errors.
>
> drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patches look good to me 1-3 applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-08-20 7:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 7:01 [PATCH 1/3] mfd: pm8921: include missing linux/module.h Jingoo Han
2013-08-20 7:28 ` Lee Jones [this message]
2013-08-20 18:31 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820072844.GF23699@lee--X1 \
--to=lee.jones@linaro.org \
--cc=bryanh@codeaurora.org \
--cc=davidb@codeaurora.org \
--cc=dwalker@fifo99.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox