Re: [PATCH 2/4] mfd: as3722: introduce core driver file

[Lee Jones <lee.jones@linaro.org>]

On Tue, 20 Aug 2013, Florian Lobmaier wrote:

> 
> Signed-off-by: Florian Lobmaier <florian.lobmaier@ams.com>
> ---
>  drivers/mfd/as3722-core.c |  747 +++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 747 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mfd/as3722-core.c

This patch needs to be broken down quite a lot. First add the very
basic probe()ing and remove()ing code. Just enough to turn the device
on and do a version check etc.

Then in the next patch, allocate your resources, or a similar
activity. Then patch by patch, build it up do what it is now. Attempt
to add the headers at the appropriate times too. Although, if you
don't know what they all do, I won't be too stringent on that. Just
make sure that you don't add any regmap headers before you use any
regmap functionality, that kind of thing.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog