From: Lee Jones <lee.jones@linaro.org>
To: Florian Lobmaier <florian.lobmaier@ams.com>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com
Subject: Re: [PATCH 4/4] mfd: as3722: introduce regmap support
Date: Tue, 20 Aug 2013 13:08:00 +0100 [thread overview]
Message-ID: <20130820120800.GN23699@lee--X1> (raw)
In-Reply-To: <1376997210-32631-5-git-send-email-florian.lobmaier@ams.com>
On Tue, 20 Aug 2013, Florian Lobmaier wrote:
>
> Signed-off-by: Florian Lobmaier <florian.lobmaier@ams.com>
> ---
> drivers/mfd/as3722-regmap.c | 417 +++++++++++++++++++++++++++++++++++++++++++
> 1 files changed, 417 insertions(+), 0 deletions(-)
> create mode 100644 drivers/mfd/as3722-regmap.c
I'll leave the review of this file to Mark, but it should be added
either when you start calling the functions, or at least before they
are used, or else the preceding commits won't build. This would cause
someone a major headache if their bisect landed in the middle of your
patches.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-08-20 12:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 11:13 mfd: as3722: introducing ams AS3722 PMIC driver Florian Lobmaier
2013-08-20 11:13 ` [PATCH 1/4] mfd: as3722: driver introduction in Kconfig and Makefile Florian Lobmaier
2013-08-20 11:59 ` Lee Jones
2013-08-20 11:13 ` [PATCH 2/4] mfd: as3722: introduce core driver file Florian Lobmaier
2013-08-20 12:03 ` Lee Jones
2013-08-20 11:13 ` [PATCH 3/4] mfd: as3722: introduce platform and register include files Florian Lobmaier
2013-08-20 12:05 ` Lee Jones
2013-08-20 11:13 ` [PATCH 4/4] mfd: as3722: introduce regmap support Florian Lobmaier
2013-08-20 12:08 ` Lee Jones [this message]
2013-08-21 18:28 ` Mark Brown
2013-08-22 9:25 ` Lee Jones
2013-08-21 18:30 ` Mark Brown
2013-08-20 11:56 ` mfd: as3722: introducing ams AS3722 PMIC driver Lee Jones
2013-08-20 12:32 ` Lee Jones
2013-08-20 12:39 ` Florian Lobmaier
2013-08-20 13:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820120800.GN23699@lee--X1 \
--to=lee.jones@linaro.org \
--cc=florian.lobmaier@ams.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox