Re: mfd: as3722: introducing ams AS3722 PMIC driver

[Lee Jones <lee.jones@linaro.org>]

On Tue, 20 Aug 2013, Florian Lobmaier wrote:
> On Tue, 20 Aug 2013, Lee Jones wrote:
> > - http://kparal.wordpress.com/2011/08/18/git-tip-of-the-day-splitting-changes-into-several-patches/
> 
> > - http://nuclearsquid.com/writings/git-add/
> 
> Thank you very much for your hints and clarification on how to split up the patches. I think this point is clear to me now. We will need of course some time to split up the patches as requested.

No problem. Take as much time as you need.

> In addition, how to deal with the sub-drivers of the mfd? Should those be included in the mfd driver patch as they are introduced or should they be treated as separate units?

As long as each commit can be built as it's added and the pieces are
kept reasonably small, it doesn't matter too much. In an ideal world
each patch will only pertain to a single file, but sometimes adding
something in one file doesn't make any sense without the addition of
corresponding code in a related driver.

Just try to keep them separate with regards to subsystems, or else
matter will be complicated somewhat.

> Thanks again for your help, but as you might have already recognized, we are kernel newbies. At least in terms of getting code upstream.

That's fine. Everyone has to start from somewhere.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog