* [PATCH 1/3] mfd: pm8921: include missing linux/module.h
@ 2013-08-20 7:01 Jingoo Han
2013-08-20 7:28 ` Lee Jones
2013-08-20 18:31 ` David Brown
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-20 7:01 UTC (permalink / raw)
To: Samuel Ortiz, Lee Jones
Cc: linux-kernel, David Brown, Daniel Walker, Bryan Huntsman,
Jingoo Han
Include <linux/module.h> in order to fix the following errors.
drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/mfd/pm8921-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 9be6840..bd4b37c 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -14,6 +14,7 @@
#define pr_fmt(fmt) "%s: " fmt, __func__
#include <linux/kernel.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/err.h>
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] mfd: pm8921: include missing linux/module.h
2013-08-20 7:01 [PATCH 1/3] mfd: pm8921: include missing linux/module.h Jingoo Han
@ 2013-08-20 7:28 ` Lee Jones
2013-08-20 18:31 ` David Brown
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-08-20 7:28 UTC (permalink / raw)
To: Jingoo Han
Cc: Samuel Ortiz, linux-kernel, David Brown, Daniel Walker,
Bryan Huntsman
On Tue, 20 Aug 2013, Jingoo Han wrote:
> Include <linux/module.h> in order to fix the following errors.
>
> drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
> drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Patches look good to me 1-3 applied.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/3] mfd: pm8921: include missing linux/module.h
2013-08-20 7:01 [PATCH 1/3] mfd: pm8921: include missing linux/module.h Jingoo Han
2013-08-20 7:28 ` Lee Jones
@ 2013-08-20 18:31 ` David Brown
1 sibling, 0 replies; 3+ messages in thread
From: David Brown @ 2013-08-20 18:31 UTC (permalink / raw)
To: Jingoo Han
Cc: Samuel Ortiz, Lee Jones, linux-kernel, Daniel Walker,
Bryan Huntsman
On Tue, Aug 20, 2013 at 04:01:26PM +0900, Jingoo Han wrote:
>Include <linux/module.h> in order to fix the following errors.
>
>drivers/mfd/pm8921-core.c:209:16: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:210:20: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:211:16: error: expected declaration specifiers or '...' before string constant
>drivers/mfd/pm8921-core.c:212:14: error: expected declaration specifiers or '...' before string constant
>
>Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>---
> drivers/mfd/pm8921-core.c | 1 +
> 1 file changed, 1 insertion(+)
Acked-by: David Brown <davidb@codeaurora.org>
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-20 18:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-20 7:01 [PATCH 1/3] mfd: pm8921: include missing linux/module.h Jingoo Han
2013-08-20 7:28 ` Lee Jones
2013-08-20 18:31 ` David Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).