From: Oleg Nesterov <oleg@redhat.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Brad Spengler <spender@grsecurity.net>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Colin Walters <walters@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: PATCH? fix unshare(NEWPID) && vfork()
Date: Tue, 20 Aug 2013 20:50:43 +0200 [thread overview]
Message-ID: <20130820185043.GA24040@redhat.com> (raw)
In-Reply-To: <CALCETrU4gTfzcpeEo-X7o-yZefKiw9BVNKdcN4fThUeiuZtOOg@mail.gmail.com>
On 08/20, Andy Lutomirski wrote:
>
> On Mon, Aug 19, 2013 at 11:43 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> > On 08/19, Andy Lutomirski wrote:
> >>
> >> On Mon, Aug 19, 2013 at 11:33 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> >> >
> >> > So do you think this change is fine or not (ignoring the fact it needs
> >> > cleanups) ?
> >>
> >> I think that removing the CLONE_VM check is fine (although there are
> >> some other ones that should probably be removed as well), but I'm not
> >> sure if that check needs replacing with something else.
> >
> > OK, thanks... but I still can't understand.
> >
> > The patch I sent is equivalent to the new one below. I just tried to
> > unify it with another check in do_fork().
>
> I was confused.
Andy, I do not know how much you were confused, but I bet I am confused
much more ;)
> Currently (with or without your patch), vfork() followed by
> unshare(CLONE_NEWUSER) or unshare(CLONE_NEWPID) will unshare the VM.
Could you spell please?
We never unshare the VM. CLONE_VM in sys_unshare() paths just means
"fail unless ->mm is not shared".
Oleg.
next prev parent reply other threads:[~2013-08-20 18:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 17:25 PATCH? fix unshare(NEWPID) && vfork() Oleg Nesterov
2013-08-19 17:46 ` Linus Torvalds
2013-08-19 17:51 ` Oleg Nesterov
2013-08-19 18:10 ` Andy Lutomirski
2013-08-19 18:33 ` Oleg Nesterov
2013-08-19 18:40 ` Andy Lutomirski
2013-08-19 18:43 ` Oleg Nesterov
2013-08-20 17:55 ` Eric W. Biederman
2013-08-20 18:45 ` Oleg Nesterov
2013-08-20 20:52 ` Eric W. Biederman
2013-08-21 16:35 ` Oleg Nesterov
2013-08-22 16:47 ` Oleg Nesterov
2013-08-20 17:59 ` Andy Lutomirski
2013-08-20 18:50 ` Oleg Nesterov [this message]
2013-08-20 19:00 ` Andy Lutomirski
2013-08-20 19:05 ` Oleg Nesterov
2013-08-20 19:13 ` Andy Lutomirski
2013-08-20 19:23 ` Oleg Nesterov
2013-08-20 19:38 ` Andy Lutomirski
2013-08-21 12:24 ` Oleg Nesterov
2013-08-20 20:25 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130820185043.GA24040@redhat.com \
--to=oleg@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=spender@grsecurity.net \
--cc=torvalds@linux-foundation.org \
--cc=walters@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).