Re: [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier.

Toshi Kani
2013-08-22T22:19:14Z

Hello Tejun,

On Thu, 2013-08-22 at 17:21 -0400, Tejun Heo wrote:
:
> > Local page table and memory hotplug are two separate things. That is,
> > local page tables can be supported on all NUMA platforms without hotplug
> > support. Are you sure huge mapping will solve everything for all types
> > of applications, and therefore local page tables won't be needed at all?
>
> When you throw around terms like "all" and "at all", you can't reach
> rational discussion about engineering trade-offs. I was asking you
> whether it was reasonable to do per-node page table when most machines
> support huge page mappings which makes the whole thing rather
> pointless. Of course there will be some niche cases where this might
> not be optimal but do you think that would be enough to justify the
> added complexity and churn? If you think so, can you please
> elaborate?

I am relatively new to Linux, so I am not a good person to elaborate
this. From my experience on other OS, huge pages helped for the kernel,
but did not necessarily help user applications. It depended on
applications, which were not niche cases. But Linux may be different,
so I asked since you seemed confident. I'd appreciate if you can point
us some data that endorses your statement.

> > When someone changes the page table init code, who will test it with the
> > special allocation code?
>
> What are you worrying about? Are you saying that allocating page
> table towards top or bottom of memory would be more disruptive and
> difficult to debug than pulling in ACPI init and SRAT information into
> the process? Am I missing something here?

My worry is that the code is unlikely tested with the special logic when
someone makes code changes to the page tables. Such code can easily be
broken in future.

To answer your other question/email, I believe Tang's next step is to
support local page tables. This is why we think pursing SRAT earlier is
the right direction.

Thanks,
-Toshi