Re: [PATCH 0/8] x86, acpi: Move acpi_initrd_override() earlier.

Tejun Heo
2013-08-22T21:21:22Z

Hello, Toshi.

On Thu, Aug 22, 2013 at 03:06:38PM -0600, Toshi Kani wrote:
> Since some node(s) won't be ejectable, this solution is reasonable as
> the first step. I do not think it is a distraction. I view your

But does this contribute to reaching the next step? If so, how?
I can't see how and that's why I said this was a distraction.

> suggestion as a distraction of supporting local page tables, though.

Hmmm...

> Local page table and memory hotplug are two separate things. That is,
> local page tables can be supported on all NUMA platforms without hotplug
> support. Are you sure huge mapping will solve everything for all types
> of applications, and therefore local page tables won't be needed at all?

When you throw around terms like "all" and "at all", you can't reach
rational discussion about engineering trade-offs. I was asking you
whether it was reasonable to do per-node page table when most machines
support huge page mappings which makes the whole thing rather
pointless. Of course there will be some niche cases where this might
not be optimal but do you think that would be enough to justify the
added complexity and churn? If you think so, can you please
elaborate?

> When someone changes the page table init code, who will test it with the
> special allocation code?

What are you worrying about? Are you saying that allocating page
table towards top or bottom of memory would be more disruptive and
difficult to debug than pulling in ACPI init and SRAT information into
the process? Am I missing something here?

Thanks.

--
tejun