From: David Jander <david.jander@protonic.nl>
To: Mark Brown <broonie@kernel.org>
Cc: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: regmap: bugfix in regcache-rbtree.c
Date: Wed, 21 Aug 2013 16:24:00 +0200 [thread overview]
Message-ID: <20130821162400.66c5b52e@archvile> (raw)
In-Reply-To: <20130821140816.GC26118@sirena.org.uk>
On Wed, 21 Aug 2013 15:08:16 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Wed, Aug 21, 2013 at 03:14:23PM +0200, David Jander wrote:
>
> > Here's the explanation:
>
> > 1. If a driver initializes a regmap with a RB-tree cache, and starts
> > writing to registers in some arbitrary order, you might get overlapping
> > rbnodes: Suppose I have this rb-tree (a real case I happen to have):
>
> > # cat /sys/kernel/debug/regmap/1-000a/rbtree
> > 2-19 (24)
> > 4-1b (24)
>
> Like I say this isn't supposed to be the case in the first place, those
> two nodes should be being merged - what we need to understand is where
> the overlapping nodes came from.
As I said in my last e-mail just a few seconds ago, it does happen when:
1. 4-1b is cached and 2-19 isn't yet.
2. A write access to register 2 occurs.
Hope this helps.
Best regards,
--
David Jander
Protonic Holland.
next prev parent reply other threads:[~2013-08-21 14:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 13:02 [PATCH] drivers: regmap: bugfix in regcache-rbtree.c David Jander
2013-08-21 13:14 ` David Jander
2013-08-21 14:08 ` Mark Brown
2013-08-21 14:24 ` David Jander [this message]
2013-08-21 14:41 ` David Jander
2013-08-21 13:32 ` Mark Brown
2013-08-21 14:21 ` David Jander
2013-08-21 14:44 ` Mark Brown
2013-08-21 15:08 ` David Jander
2013-08-21 15:28 ` Mark Brown
2013-08-21 17:03 ` Dimitris Papastamos
2013-08-22 10:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130821162400.66c5b52e@archvile \
--to=david.jander@protonic.nl \
--cc=broonie@kernel.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox