From: Simon Horman <horms@verge.net.au>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Daniel Lezcano'" <daniel.lezcano@linaro.org>,
"'Thomas Gleixner'" <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, "'Magnus Damm'" <damm@igel.co.jp>,
"'Paul Mundt'" <lethal@linux-sh.org>
Subject: Re: [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata()
Date: Thu, 22 Aug 2013 09:29:57 +0900 [thread overview]
Message-ID: <20130822002957.GF6902@verge.net.au> (raw)
In-Reply-To: <001b01ce9e4f$d1c97950$755c6bf0$%han@samsung.com>
On Wed, Aug 21, 2013 at 06:21:29PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
No objections for this and the following patch:
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Daniel, let me know if you would prefer if I queued these up
and sent you a pull request or you would rather just pick
them up directly.
> ---
> drivers/clocksource/sh_tmu.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
> index 78b8dae..54ab475 100644
> --- a/drivers/clocksource/sh_tmu.c
> +++ b/drivers/clocksource/sh_tmu.c
> @@ -509,7 +509,6 @@ static int sh_tmu_probe(struct platform_device *pdev)
> ret = sh_tmu_setup(p, pdev);
> if (ret) {
> kfree(p);
> - platform_set_drvdata(pdev, NULL);
> pm_runtime_idle(&pdev->dev);
> return ret;
> }
> --
> 1.7.10.4
>
>
next prev parent reply other threads:[~2013-08-22 0:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 9:21 [PATCH 1/2] clocksource: sh_tmu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-21 9:22 ` [PATCH 2/2] clocksource: sh_mtu2: " Jingoo Han
2013-08-22 0:29 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-03 6:50 [PATCH 1/2] clocksource: sh_tmu: " Jingoo Han
2013-12-04 14:54 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822002957.GF6902@verge.net.au \
--to=horms@verge.net.au \
--cc=damm@igel.co.jp \
--cc=daniel.lezcano@linaro.org \
--cc=jg1.han@samsung.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox