From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: jason@lakedaemon.net, andrew@lunn.ch,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, mturquette@linaro.org,
sebastian.hesselbarth@gmail.com, linus.walleij@linaro.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap
Date: Thu, 22 Aug 2013 10:22:08 -0300 [thread overview]
Message-ID: <20130822132207.GA27167@localhost> (raw)
In-Reply-To: <1377175611-4241-5-git-send-email-jszhang@marvell.com>
Hi Jisheng,
On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote:
> Add missing iounmap to prove error path and remove path
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
How about using devm_ioremap_resource() instead?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-08-22 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:46 [PATCH 0/4] arm: mvebu: add missing of_node_put and iounmap Jisheng Zhang
2013-08-22 12:46 ` [PATCH 1/4] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-08-22 12:46 ` [PATCH 2/4] bus: " Jisheng Zhang
2013-08-22 12:46 ` [PATCH 3/4] clk: mvebu: add missing iounmap Jisheng Zhang
2013-08-22 22:31 ` Mike Turquette
2013-08-22 12:46 ` [PATCH 4/4] pinctrl: " Jisheng Zhang
2013-08-22 13:22 ` Ezequiel Garcia [this message]
2013-08-23 18:06 ` Linus Walleij
2013-08-23 20:19 ` Ezequiel Garcia
2013-08-24 3:55 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822132207.GA27167@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jszhang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).