From: Mike Turquette <mturquette@linaro.org>
To: Jisheng Zhang <jszhang@marvell.com>, <jszhang@marvell.com>,
<jason@lakedaemon.net>, <andrew@lunn.ch>,
<gregory.clement@free-electrons.com>,
<thomas.petazzoni@free-electrons.com>,
<ezequiel.garcia@free-electrons.com>,
<sebastian.hesselbarth@gmail.com>, <linus.walleij@linaro.org>
Cc: <linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] clk: mvebu: add missing iounmap
Date: Thu, 22 Aug 2013 15:31:40 -0700 [thread overview]
Message-ID: <20130822223140.8231.74026@quantum> (raw)
In-Reply-To: <1377175611-4241-4-git-send-email-jszhang@marvell.com>
Quoting Jisheng Zhang (2013-08-22 05:46:50)
> Add missing iounmap to setup error path.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Patch looks good with one minor nitpick below.
> @@ -145,10 +147,8 @@ void __init mvebu_clk_gating_setup(struct device_node *np,
> ctrl->num_gates = n;
> ctrl->gates = kzalloc(ctrl->num_gates * sizeof(struct clk *),
> GFP_KERNEL);
> - if (WARN_ON(!ctrl->gates)) {
> - kfree(ctrl);
> - return;
> - }
> + if (WARN_ON(!ctrl->gates))
> + goto bail_out;
>
> for (n = 0; n < ctrl->num_gates; n++) {
> const char *parent =
> @@ -160,4 +160,10 @@ void __init mvebu_clk_gating_setup(struct device_node *np,
> }
>
> of_clk_add_provider(np, clk_gating_get_src, ctrl);
> +
> + return;
> +bail_out:
> + kfree(ctrl);
> +ctrl_out:
> + iounmap(base);
bail_out is not the best name. How about gates_out?
Regards,
Mike
next prev parent reply other threads:[~2013-08-22 22:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:46 [PATCH 0/4] arm: mvebu: add missing of_node_put and iounmap Jisheng Zhang
2013-08-22 12:46 ` [PATCH 1/4] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-08-22 12:46 ` [PATCH 2/4] bus: " Jisheng Zhang
2013-08-22 12:46 ` [PATCH 3/4] clk: mvebu: add missing iounmap Jisheng Zhang
2013-08-22 22:31 ` Mike Turquette [this message]
2013-08-22 12:46 ` [PATCH 4/4] pinctrl: " Jisheng Zhang
2013-08-22 13:22 ` Ezequiel Garcia
2013-08-23 18:06 ` Linus Walleij
2013-08-23 20:19 ` Ezequiel Garcia
2013-08-24 3:55 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822223140.8231.74026@quantum \
--to=mturquette@linaro.org \
--cc=andrew@lunn.ch \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jszhang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).