public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Liu Ping Fan <kernelfans@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Kevin Hao <haokexin@gmail.com>
Subject: Re: [PATCH] x86: ioapic needs check attr when programmed more than once
Date: Fri, 23 Aug 2013 09:30:52 +0200	[thread overview]
Message-ID: <20130823073052.GA25533@gmail.com> (raw)
In-Reply-To: <1377161197-3175-1-git-send-email-pingfank@linux.vnet.ibm.com>


* Liu Ping Fan <kernelfans@gmail.com> wrote:

> When programming ioapic pinX more than once, current code
> does not check whether the later attr (trigger&polarity) is the
> same as the former or not. This causes a broken semantic.
> 
> Fix it by reporting -EBUSY, when attr is different.

Was this observed in real life somehow, and if yes, what is 
the before/after behavior?

Thanks,

	Ingo

  reply	other threads:[~2013-08-23  7:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-22  8:46 [PATCH] x86: ioapic needs check attr when programmed more than once Liu Ping Fan
2013-08-23  7:30 ` Ingo Molnar [this message]
2013-08-23  8:04   ` Liu ping fan
2013-08-23  8:09     ` Liu ping fan
2013-08-23  8:23       ` Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2013-08-23  8:58 Liu Ping Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130823073052.GA25533@gmail.com \
    --to=mingo@kernel.org \
    --cc=haokexin@gmail.com \
    --cc=hpa@zytor.com \
    --cc=kernelfans@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox