From: Peter Zijlstra <peterz@infradead.org>
To: Jiejing Zhang <jiejzhang@nvidia.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Jiejing Zhang <kzjeef@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Eric Miao <emiao@nvidia.com>
Subject: Re: [PATCH] ftrace: add tgid information in task switch event.
Date: Fri, 23 Aug 2013 12:12:49 +0200 [thread overview]
Message-ID: <20130823101249.GR31370@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <52171E4F.2020109@nvidia.com>
On Fri, Aug 23, 2013 at 04:33:19PM +0800, Jiejing Zhang wrote:
>
> On 08/21/2013 11:23 PM, Peter Zijlstra wrote:
> >On Wed, Aug 21, 2013 at 11:09:44AM -0400, Steven Rostedt wrote:
> >>>From: Jiejing Zhang <jiejzhang@nvidia.com>
> >>>
> >>>ftrace only report pid in task switch event, which is
> >>>actually thread ID in user space view, the comm of
> >>>the thread will be like "Thread-1", "Compiler", etc
> >>>in android system, it's useful if we can add tgid
> >>>information in ftrace event to find out the process
> >>>id, and the process id's comm will help us to figure
> >>>out the application, which was useful on data analysis
> >>>tools.
> >Meh.. are you telling me you really can't do that otherwise?
> >
> >Adding this information makes the tracepoint slower for everybody else.
> >How about you enable trace_sched_process_fork() and track things that
> >way?
> Thanks for the tip, I have tried fix this by avoid add tgid in ftrace,
> actually the relationship between thread and process can be figure by
> analysis these two command's output:
> `ps aTH -F` and `ps a -F`
Yeah, or prod around in /proc yourself.
> also with fork event, it can totally avoid add such a patch in kernel.
Kinda depends on when you start tracing, if you start tracing when
everything is already running you'll need a /proc state dump for the
current state and the fork tracepoint can then update you on new tasks.
Anyway, good to hear this works for you.
prev parent reply other threads:[~2013-08-23 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 15:05 [PATCH] ftrace: add tgid information in task switch event Jiejing Zhang
2013-08-21 15:09 ` Steven Rostedt
2013-08-21 15:23 ` Peter Zijlstra
2013-08-23 8:33 ` Jiejing Zhang
2013-08-23 10:12 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130823101249.GR31370@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=emiao@nvidia.com \
--cc=fweisbec@gmail.com \
--cc=jiejzhang@nvidia.com \
--cc=kzjeef@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox