Re: [PATCH v2] Makefile: enable -Werror=implicit-int and -Werror=strict-prototypes by default

Andrew Morton
2013-08-15T21:18:51Z

On Thu, 15 Aug 2013 21:37:31 +0300 Sergei Trofimovich <slyfox@gentoo.org> wrote:

> The common error type found in forward-ported/backported patches is missing headers.
> One recent example (files and function names are mangled):
>
> void foo(){}
> EXPORT_SYMBOL(foo);
>
> gave only warning
>
> foo.c:12345678:5: warning: function declaration isn't a prototype [-Wstrict-prototypes]
> void foo(){}
> ^
>
> foo.c:12345679:5: warning: data definition has no type or storage class [enabled by default]
> EXPORT_SYMBOL(foo);
> foo.c:12345679:5: warning: type defaults to 'int' in declaration of 'EXORT_SYMBOL' [-Werror=implicit-int]
>
> Now it's a fata error. Tested on x86_64 allyesconfig.

Yes, let's try that.

Partly because the build still generates far too many warnings..