From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: jason@lakedaemon.net, andrew@lunn.ch,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com, mturquette@linaro.org,
sebastian.hesselbarth@gmail.com, linus.walleij@linaro.org,
linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] pinctrl: mvebu: Convert to use devm_ioremap_resource
Date: Sat, 24 Aug 2013 12:06:25 -0300 [thread overview]
Message-ID: <20130824150624.GA12907@localhost> (raw)
In-Reply-To: <1377225242-5854-5-git-send-email-jszhang@marvell.com>
Hi Jisheng,
On Fri, Aug 23, 2013 at 10:34:02AM +0800, Jisheng Zhang wrote:
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
Mmm.. I would prefer to see a better commit log for this patch.
In particular, the current code is buggy (for there's a leak) and
this patch fixes it.
Care to write something meaningful and re-send? (except the patch
Mike already took, I guess).
With that changes you can add:
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>T
for the whole series.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-08-24 15:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 2:33 [PATCH v2 0/4] arm: mvebu: fix resource leak Jisheng Zhang
2013-08-23 2:33 ` [PATCH v2 1/4] arm: mvebu: add missing of_node_put() to fix reference leak Jisheng Zhang
2013-08-23 2:34 ` [PATCH v2 2/4] bus: " Jisheng Zhang
2013-08-23 2:34 ` [PATCH v2 3/4] clk: mvebu: add missing iounmap Jisheng Zhang
2013-08-23 21:29 ` Mike Turquette
2013-08-24 3:53 ` Jisheng Zhang
2013-08-23 2:34 ` [PATCH v2 4/4] pinctrl: mvebu: Convert to use devm_ioremap_resource Jisheng Zhang
2013-08-24 15:06 ` Ezequiel Garcia [this message]
2013-08-26 9:59 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130824150624.GA12907@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jszhang@marvell.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).