* [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()
@ 2013-08-21 9:52 Jingoo Han
2013-08-22 1:31 ` Shawn Guo
2013-08-25 9:07 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Jingoo Han @ 2013-08-21 9:52 UTC (permalink / raw)
To: 'Vinod Koul'
Cc: 'Dan Williams', linux-kernel, 'Andy Shevchenko',
'Jingoo Han', 'Fabio Estevam',
'Shawn Guo', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/dma/ipu/ipu_idmac.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
index 608d4a2..cb9c0bc 100644
--- a/drivers/dma/ipu/ipu_idmac.c
+++ b/drivers/dma/ipu/ipu_idmac.c
@@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
iounmap(ipu->reg_ic);
iounmap(ipu->reg_ipu);
tasklet_kill(&ipu->tasklet);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()
2013-08-21 9:52 [PATCH] dma: ipu: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-22 1:31 ` Shawn Guo
2013-08-25 9:07 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-08-22 1:31 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Vinod Koul', 'Dan Williams', linux-kernel,
'Andy Shevchenko', 'Fabio Estevam'
On Wed, Aug 21, 2013 at 06:52:54PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> drivers/dma/ipu/ipu_idmac.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 608d4a2..cb9c0bc 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1764,7 +1764,6 @@ static int ipu_remove(struct platform_device *pdev)
> iounmap(ipu->reg_ic);
> iounmap(ipu->reg_ipu);
> tasklet_kill(&ipu->tasklet);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma: ipu: remove unnecessary platform_set_drvdata()
2013-08-21 9:52 [PATCH] dma: ipu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 1:31 ` Shawn Guo
@ 2013-08-25 9:07 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2013-08-25 9:07 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Dan Williams', linux-kernel, 'Andy Shevchenko',
'Fabio Estevam', 'Shawn Guo'
On Wed, Aug 21, 2013 at 06:52:54PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
Applied, thanks
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-25 9:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-21 9:52 [PATCH] dma: ipu: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-22 1:31 ` Shawn Guo
2013-08-25 9:07 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox