* [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata()
@ 2013-08-26 0:32 Jingoo Han
2013-08-26 8:24 ` Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-26 0:32 UTC (permalink / raw)
To: 'Vinod Koul'
Cc: 'Dan Williams', linux-kernel, 'Simon Horman',
'Andy Shevchenko', 'Fabio Estevam',
'Shawn Guo', 'Jingoo Han'
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/dma/sh/shdmac.c | 3 ---
drivers/dma/sh/sudmac.c | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index c7faded..282e93f 100755
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -882,7 +882,6 @@ rst_err:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&shdev->shdma_dev);
eshdma:
synchronize_rcu();
@@ -911,8 +910,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
sh_dmae_chan_remove(shdev);
shdma_cleanup(&shdev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
-
synchronize_rcu();
return 0;
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
index 3c7d2b8..bf85b8e 100755
--- a/drivers/dma/sh/sudmac.c
+++ b/drivers/dma/sh/sudmac.c
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev)
chan_probe_err:
sudmac_chan_remove(su_dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&su_dev->shdma_dev);
return err;
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev)
dma_async_device_unregister(dma_dev);
sudmac_chan_remove(su_dev);
shdma_cleanup(&su_dev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata()
2013-08-26 0:32 [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata() Jingoo Han
@ 2013-08-26 8:24 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2013-08-26 8:24 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Dan Williams', linux-kernel, 'Simon Horman',
'Andy Shevchenko', 'Fabio Estevam',
'Shawn Guo'
On Mon, Aug 26, 2013 at 09:32:05AM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.
Applied, thanks
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-26 9:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 0:32 [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata() Jingoo Han
2013-08-26 8:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox