Re: [PATCH] pinctrl: rockchip: Simplify pin_to_bank equation

Heiko Stübner
2013-08-26T08:33:42Z

Am Freitag, 23. August 2013, 09:49:00 schrieb Axel Lin:
> If (b->pin_base + b->nr_pins - 1) < pin is true, pin >= b->pin_base is
> always true because b->nr_pins is never less than 0.
> Thus this patch simplify the equation.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Heiko Stuebner <heiko@sntech.de>

> ---
> drivers/pinctrl/pinctrl-rockchip.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 319a64a..ea27806 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -186,8 +186,7 @@ static struct rockchip_pin_bank *pin_to_bank(struct
> rockchip_pinctrl *info, {
> struct rockchip_pin_bank *b = info->ctrl->pin_banks;
>
> - while ((pin >= b->pin_base) &&
> - ((b->pin_base + b->nr_pins - 1) < pin))
> + while (pin >= (b->pin_base + b->nr_pins))
> b++;
>
> return b;