From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Guenter Roeck <linux@roeck-us.net>, Meelis Roos <mroos@linux.ee>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steve Cotton <steve@s.cotton.clara.co.uk>,
USB list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume
Date: Mon, 26 Aug 2013 08:38:40 -0700 [thread overview]
Message-ID: <20130826153840.GA29862@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1308261051340.1445-100000@iolanthe.rowland.org>
On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
> Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
> ohci-pci.c) added missing ohci_suspend and ohci_resume callback
> pointers, but forgot that these callbacks are declared and defined
> only when CONFIG_PM is enabled.
>
> This patch adds a preprocessor conditional to avoid build errors when
> PM is disabled.
>
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
>
> ---
Guenter and Meelis, does the patch below fix the problem for you?
thanks,
greg k-h
next prev parent reply other threads:[~2013-08-26 15:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 3:30 Commit 9a11899 (USB: OHCI: add missing PCI PM callbacks to ohci-pci.c) breaks several builds Guenter Roeck
2013-08-26 4:02 ` Guenter Roeck
2013-08-26 4:26 ` Greg Kroah-Hartman
2013-08-26 4:56 ` Guenter Roeck
2013-08-26 14:47 ` Alan Stern
2013-08-26 14:53 ` [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume Alan Stern
2013-08-26 15:38 ` Greg Kroah-Hartman [this message]
2013-08-26 16:06 ` Guenter Roeck
2013-08-26 16:50 ` Greg Kroah-Hartman
2013-08-26 17:19 ` Guenter Roeck
2013-08-26 22:14 ` Greg Kroah-Hartman
2013-08-26 22:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826153840.GA29862@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mroos@linux.ee \
--cc=stern@rowland.harvard.edu \
--cc=steve@s.cotton.clara.co.uk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox