From: Greg KH <greg@kroah.com>
To: Shawn Bohrer <sbohrer@rgmadvisors.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
tomk@rgmadvisors.com
Subject: Re: [PATCH] USB: Fix compilation error when CONFIG_PM disabled
Date: Mon, 26 Aug 2013 09:47:09 -0700 [thread overview]
Message-ID: <20130826164709.GA1858@kroah.com> (raw)
In-Reply-To: <1377534914-7145-1-git-send-email-sbohrer@rgmadvisors.com>
On Mon, Aug 26, 2013 at 11:35:14AM -0500, Shawn Bohrer wrote:
> Commit 9a11899c5e699a8d "USB: OHCI: add missing PCI PM callbacks to
> ohci-pci.c" Introduced the following compilation errors when power
> management is disabled:
>
> drivers/usb/host/ohci-pci.c: In function 'ohci_pci_init':
> drivers/usb/host/ohci-pci.c:309:35: error: 'ohci_suspend' undeclared (first use in this function)
> drivers/usb/host/ohci-pci.c:309:35: note: each undeclared identifier is reported only once for each function it appears in
> drivers/usb/host/ohci-pci.c:310:34: error: 'ohci_resume' undeclared (first use in this function)
>
> ohci_suspend and ohci_resume are only defined when CONFIG_PM is defined
> so only use them under CONFIG_PM.
>
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
Alan sent this patch an hour or so ago, sorry.
I'll add your Signed-off-by: to his patch though, when I queue it up for
Linus in a few hours (I'm in an airport at the moment...)
thanks,
greg k-h
prev parent reply other threads:[~2013-08-26 16:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 16:35 [PATCH] USB: Fix compilation error when CONFIG_PM disabled Shawn Bohrer
2013-08-26 16:44 ` Alan Stern
2013-08-26 16:47 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130826164709.GA1858@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sbohrer@rgmadvisors.com \
--cc=stern@rowland.harvard.edu \
--cc=tomk@rgmadvisors.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox