Re: [PATCH] USB: OHCI: fix build error related to ohci_suspend/resume

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Mon, Aug 26, 2013 at 09:06:27AM -0700, Guenter Roeck wrote:
> On Mon, Aug 26, 2013 at 08:38:40AM -0700, Greg Kroah-Hartman wrote:
> > On Mon, Aug 26, 2013 at 10:53:53AM -0400, Alan Stern wrote:
> > > Commit 9a11899c5e69 (USB: OHCI: add missing PCI PM callbacks to
> > > ohci-pci.c) added missing ohci_suspend and ohci_resume callback
> > > pointers, but forgot that these callbacks are declared and defined
> > > only when CONFIG_PM is enabled.
> > > 
> > > This patch adds a preprocessor conditional to avoid build errors when
> > > PM is disabled.
> > > 
> > > Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> > > 
> > > ---
> > 
> > Guenter and Meelis, does the patch below fix the problem for you?
> > 
> Tested-by: Guenter Roeck <linux@roeck-us.net>
> 
> Previously failing builds:
> 	mips:ath79_defconfig
> 	powerpc:ppc64e_defconfig
> 	powerpc:cell_defconfig
> 	powerpc:maple_defconfig
> 	parisc:defconfig
> 	tile:defconfig
> 	sparc32:defconfig
> 	sparc64:defconfig
> 
> 	as well as the powerpc qemu test (with the config file used
> 	by the yocto project)
> 
> All builds pass with the patch applied, as does the qemu test.

Thanks for testing, I'll queue it up later today (at an airport right
now, about to board a flight), and send it to Linus later tonight if no
one else has any problems with it.

thanks,

greg k-h